From owner-svn-ports-head@freebsd.org  Thu Aug  6 03:34:40 2020
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id CE6503B01E9;
 Thu,  6 Aug 2020 03:34:40 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4BMYyS4nqtz4ZRl;
 Thu,  6 Aug 2020 03:34:40 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 956EE2D1B; Thu,  6 Aug 2020 03:34:40 +0000 (UTC)
Date: Thu, 6 Aug 2020 03:34:40 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Danilo Egea Gondolfo <danilo@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r544245 - head/x11/sakura
Message-ID: <20200806033440.GA53929@FreeBSD.org>
References: <202008052155.075LtmtD072730@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202008052155.075LtmtD072730@repo.freebsd.org>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Aug 2020 03:34:40 -0000

On Wed, Aug 05, 2020 at 09:55:48PM +0000, Danilo Egea Gondolfo wrote:
> New Revision: 544245
> URL: https://svnweb.freebsd.org/changeset/ports/544245
> 
> @@ -14,9 +14,10 @@ LICENSE=	GPLv2
>  LIB_DEPENDS=	libgnutls.so:security/gnutls \
>  		libpcre2-8.so:devel/pcre2
>  
> +USES=		cmake gnome pkgconfig gettext perl5 tar:bz2 xorg
> +
>  OPTIONS_DEFINE=	DOCS
>  
> -USES=		cmake gnome pkgconfig gettext perl5 xorg
>  USE_GNOME=	cairo gdkpixbuf2 vte3
>  USE_XORG=	x11
>  USE_PERL5=	build

I'd argue that USES was placed better before this change (right next to
USE_FOO knobs).  It should've been left where it was and OPTIONS_DEFINE
moved downwards instead.

./danfe