From owner-freebsd-current@FreeBSD.ORG Fri Dec 12 17:19:59 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BC3AF16A4CE; Fri, 12 Dec 2003 17:19:59 -0800 (PST) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id C284E43D3C; Fri, 12 Dec 2003 17:19:55 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id MAA29233; Sat, 13 Dec 2003 12:19:45 +1100 Date: Sat, 13 Dec 2003 12:19:47 +1100 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: bremner@unb.ca In-Reply-To: <0t4qw61041.wl@nohost.unb.ca> Message-ID: <20031213121725.N2797@gamplex.bde.org> References: <20031114080021.L3913@gamplex.bde.org> <20031127144834.Y77022@gamplex.bde.org><0t4qw61041.wl@nohost.unb.ca> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: freebsd-current@freebsd.org Subject: Re: atapicam broken by ata_lowlevel.c rev.1.23 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Dec 2003 01:19:59 -0000 On Fri, 12 Dec 2003 bremner@unb.ca wrote: > At Thu, 27 Nov 2003 00:07:30 -0600, > Dan Nelson wrote: > > > > In the last episode (Nov 27), Bruce Evans said: > > > [Resending due to no response after 2 weeks.] > > > > > > Rev.1.23 of ata-lowlevel.c broke atapicam on my BP6 system as shown > > > by the enclosed boot -v messages (the system just hangs, apparently > > > waiting for a disk interrupt that never arrives; there seems to be no > > > timeout). > > > > If it's any consolation: "me too" :) Backing out 1.23 worked for me as > > well. The system that I saw the hang on isn't SMP. I also > > pre-emptively patched another SMP system before I had to drive in to > > fix it if it hung. > > I just wanted to report that my boot hang problems (which were "cured" > by reverting to revision 1.22 of ata-lowlevel.c) have gone away with > 5.2-RC1; more precisely with 5.2-CURRENT of Dec. 10. This was fixed (apparently without knowing about all the reports of the bug's realized potential) in: % RCS file: /home/ncvs/src/sys/dev/ata/atapi-cam.c,v % Working file: atapi-cam.c % head: 1.29 % ... % ---------------------------- % revision 1.29 % date: 2003/12/05 01:02:46; author: scottl; state: Exp; lines: +1 -1 % Fix a potential problem with atapi-cam where an incorrect flag is passed % into the ata queueing layer. % % Approved by: re % ---------------------------- Bruce