From owner-svn-src-all@FreeBSD.ORG  Sat Nov 29 14:40:56 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 540D8B44;
 Sat, 29 Nov 2014 14:40:56 +0000 (UTC)
Received: from mail.turbocat.net (mail.turbocat.net
 [IPv6:2a01:4f8:d16:4514::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 14D6EED1;
 Sat, 29 Nov 2014 14:40:55 +0000 (UTC)
Received: from laptop015.home.selasky.org
 (cm-176.74.213.204.customer.telag.net [176.74.213.204])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id 8A77A1FE022;
 Sat, 29 Nov 2014 15:40:52 +0100 (CET)
Message-ID: <5479DB0C.5010208@selasky.org>
Date: Sat, 29 Nov 2014 15:41:16 +0100
From: Hans Petter Selasky <hps@selasky.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: Takahashi Yoshihiro <nyan@FreeBSD.org>, src-committers@freebsd.org, 
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r275241 - head/sys/boot/pc98/boot2
References: <201411291222.sATCMWJv060917@svn.freebsd.org>
In-Reply-To: <201411291222.sATCMWJv060917@svn.freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Nov 2014 14:40:56 -0000

On 11/29/14 13:22, Takahashi Yoshihiro wrote:
> +	    if (k = ep - arg) {

There is a missing set of parenthesis here, GCC will complain!

>  		} else if (c == 'S') {
>  		    j = 0;
> -		    while ((unsigned int)(i = *arg++ - '0') <= 9)
> +		    while ((i = *arg++ - '0') <= 9)
>  			j = j * 10 + i;
>  		    if (j > 0 && i == -'0') {
>  			comspeed = j;

Like Bruce said, this code does no longer handle negative values of "i" 
like before!

BTW: If we want to squeeze more bytes out, we should consider something 
like compressing the code, perhaps using something like Farbraush ??

--HPS