From owner-freebsd-fcp@freebsd.org Tue Sep 3 21:16:36 2019 Return-Path: Delivered-To: freebsd-fcp@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3E539D8716 for ; Tue, 3 Sep 2019 21:16:36 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46NKWl6mjVz4Nw5 for ; Tue, 3 Sep 2019 21:16:35 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id E524DD8713; Tue, 3 Sep 2019 21:16:35 +0000 (UTC) Delivered-To: fcp@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E4CB0D8712; Tue, 3 Sep 2019 21:16:35 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46NKWk4DsWz4Nw4; Tue, 3 Sep 2019 21:16:34 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pl1-x636.google.com with SMTP id y10so2587984pll.7; Tue, 03 Sep 2019 14:16:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=w8Vx4d3esKc2z/JGyebJiyqldEjepkegxAZK6YCBasY=; b=fLml44ijyN6x6a1UVrybJ1hk5VFpUD8T9iVw1TD/DMaDh1EreulyiLzYrNXT4+eUvd yJxh1lXgJHKsQpma+wj85RWI/3BOPFgR7DPff3YUHrSNzq/82++nPosLz3IUIlut0OaD y7EbRgytKgKMqKrhGh1uu9G6ORXawuHy8OluDZF0b0GnGVjrPHUReCl9D7VsVsAmaMj+ /g2d6OPdmIstHYSrbh6DLmz1x4f9hV6UOZFEZyMYdO1jn7gWGxUh8qpS5GfT/yZcVu90 gLwiksnFPqElhehRncywa0xuQALuf+Mgj7hOLmgXFCvdIXNaqSsyaXMqLM++Ej2DkS5t SfkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=w8Vx4d3esKc2z/JGyebJiyqldEjepkegxAZK6YCBasY=; b=s5bagUuzMqAZo3oNveQIU5eUVSQrwvN3fjVjCUUxB0ZGVbCvy0u4zkVNgBRKwGxFCN bPgspnQJfkZkCInNyvNRtHUy+UTkmVbR7wmhCtBrsU+hmt6mNV+bChcHcMp4SuacqpIF w6bwwoh4CDFkjtFvsJTpErHjwljv8DbRfOuqQJMmaeqT9Q7VnBh4rC5mxpve0xP65gdT KYAdDr7QeMRBUINd4XwyBzbaIG4MxowandAFl7wYiEU86NrxuFNBQzidT4RtfJnPbSAB Ctjda7hahwIft6YiQuMV04rHA2sPD8fj0JQy7eNDxNW5HIhWfAn8ZrAkoTmZXW03Y6ol Ixxg== X-Gm-Message-State: APjAAAU9AA8OdBdW+nC+BYaEWRashOfz0i3gl7yV/sRAfpdfuXC3810D 1FgWcwr7rlEPJt8GkaT487v3UN9MXz4= X-Google-Smtp-Source: APXvYqyN6s5LsHpf6BjkraLhqPrWzWg2OMn86gzi8pMi02qKuKDXC1jnMmpw7bksQoZwP58/ce3NIw== X-Received: by 2002:a17:902:a506:: with SMTP id s6mr9802606plq.232.1567545392268; Tue, 03 Sep 2019 14:16:32 -0700 (PDT) Received: from ?IPv6:2607:fb90:b285:cd60:7950:2070:2ff0:7781? ([2607:fb90:b285:cd60:7950:2070:2ff0:7781]) by smtp.gmail.com with ESMTPSA id d18sm12189880pfr.133.2019.09.03.14.16.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Sep 2019 14:16:31 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (1.0) Subject: Re: FCP 20190401-ci_policy: CI policy From: Enji Cooper X-Mailer: iPhone Mail (16G77) In-Reply-To: <201909021512.x82FC8ZD009673@gndrsh.dnsmgr.net> Date: Tue, 3 Sep 2019 14:16:30 -0700 Cc: Cy Schubert , Hans Petter Selasky , Ed Maste , FreeBSD Hackers , fcp@freebsd.org, Li-Wen Hsu Content-Transfer-Encoding: quoted-printable Message-Id: <911BCF8B-CF37-48A5-B3FE-B5959575A996@gmail.com> References: <201909021512.x82FC8ZD009673@gndrsh.dnsmgr.net> To: "Rodney W. Grimes" X-Rspamd-Queue-Id: 46NKWk4DsWz4Nw4 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=fLml44ij; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::636 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com X-Spamd-Result: default: False [-3.49 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MV_CASE(0.50)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCPT_COUNT_SEVEN(0.00)[7]; NEURAL_HAM_SHORT(-0.99)[-0.987,0]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.00)[ip: (-9.21), ipnet: 2607:f8b0::/32(-2.77), asn: 15169(-2.28), country: US(-0.05)]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[6.3.6.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-fcp@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD Community Proposals List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2019 21:16:36 -0000 On Sep 2, 2019, at 08:12, Rodney W. Grimes w= rote: >> In message <8350379A-30F8-4BBD-B9AE-A3A176CAE966@gmail.com>, Enji Cooper=20= >> writes >> : >>>=20 >>>=20 >>>> On Sep 1, 2019, at 10:42 AM, Hans Petter Selasky wrot= e: >>>>=20 >>>> Hi, >>>>=20 >>>> If the fallouts could be better organized through some simple guideline= s, t >>> hat would be more accepted I think: >>>>=20 >>>> 1) Don't commit stuff before going off work. Even though a change looks= inn >>> ocent, it might break something and you'll need to fix it. >>>>=20 >>>> 2) Organize big changes going into the kernel, to ease debugging and ge= ttin >>> g things back on track again. >>>>=20 >>>> 3) If your patch is risky, commit it on a Monday. Don't wait until Frid= ay. >>>>=20 >>>> Failure to follow the rules may have consequences like other senior dev= elop >>> ers kicking in and doing temporary reverts until issues are resolved. >>>=20 >>> Agreed. There???s a reason why at my most former job (FB) we generally k= new b >>> etter than to commit code on a Friday. It would cause the weekend oncall= s a l >>> ot of grief. >>>=20 >>> Let???s put it this way: think of it like being oncall for code. If you d= on?? >>> ?t have someone else to work with who can manage it, would you like to b= e pag >>> ed if something went south with your code committed on a Friday? >>=20 >> This is a good idea. Pinging someone to provide backup support is a good=20= >> idea. phk@ has asked me in this regard once giving me authority to back o= ut=20 >> his commit should it cause any grief. It didn't break anything but he mad= e=20 >> contingency plans just in case. >=20 > All of these can be codified into "operational suggestions" and added to t= he > committers guide, and does not necessarily need to be rules, policy or=20 > procedure, that should help move it forward past the high bar of trying to= > get changes like this codified some place that everyone can read. I agree with you in spirit. It just makes it easier if it=E2=80=99s implemen= ted in a structured process, so I don=E2=80=99t have to look up the committe= r=E2=80=99s guide to figure out what the rules are, then apply them. -Enji=