From owner-cvs-all@FreeBSD.ORG Sat Sep 4 08:47:17 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A615116A4CE; Sat, 4 Sep 2004 08:47:17 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id A847543D55; Sat, 4 Sep 2004 08:47:16 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i848l9al011933 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 4 Sep 2004 11:47:10 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id i848l9Rs091418; Sat, 4 Sep 2004 11:47:09 +0300 (EEST) (envelope-from ru) Date: Sat, 4 Sep 2004 11:47:09 +0300 From: Ruslan Ermilov To: Ken Smith Message-ID: <20040904084709.GB91367@ip.net.ua> References: <200409040023.i840NATf061895@repoman.freebsd.org> <20040904002516.GC29470@electra.cse.Buffalo.EDU> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3lcZGd9BuhuYXNfi" Content-Disposition: inline In-Reply-To: <20040904002516.GC29470@electra.cse.Buffalo.EDU> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: Ken Smith Subject: Re: cvs commit: src/sys/conf newvers.sh X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Sep 2004 08:47:17 -0000 --3lcZGd9BuhuYXNfi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 03, 2004 at 08:25:17PM -0400, Ken Smith wrote: > On Sat, Sep 04, 2004 at 12:23:10AM +0000, Ken Smith wrote: > > kensmith 2004-09-04 00:23:10 UTC > >=20 > > FreeBSD src repository > >=20 > > Modified files: (Branch: RELENG_5) > > sys/conf newvers.sh=20 > > Log: > > Another forced commit with no approval line, hoping this time it fail= s. > > =20 > > Revision Changes Path > > 1.62.2.6 +0 -0 src/sys/conf/newvers.sh >=20 > Ok, the line for RELENG_5 looking different than the rest of the lines > in the approvers file was my best guess at why the approval checks > weren't working. Anyone else got any ideas? >=20 I played with this a bit, setting up a local repository with FreeBSD CVSROOT scripts, and I cannot reproduce it. Committing to RELENG_5 of newvers.sh (which was copied from the FreeBSD repo) results in the following: : cvs commit: Examining . : Use of uninitialized value in sprintf at /home/ru/XXX/CVSROOT/commitcheck= line 44. : 2508 Repos: src/sys/conf : 2508 =3D=3D=3D=3D src/sys/conf/newvers.sh : 2508 Tag: RELENG_5 : 2508 Avail: /home/ru/XXX/CVSROOT/avail : 2514: pgrp: 2504 : 2514: committer: ru : 2514: args: /home/ru/tmp/cvsSx1Z4U : 2514: log:=20 : 2514: files_file: tag=3DRELENG_5, file=3Dsrc/sys/conf/newvers.sh : 2514: Read /home/ru/XXX/CVSROOT/approvers : 2514: checking: ^src/, RELENG_5, re : 2514: file matched (src/sys/conf/newvers.sh, ^src/) : 2514: tag matched (RELENG_5, RELENG_5) : 2514: log not matched ( : , re) : **** You need "Approved by: re" line in your log entry. : cvs [commit aborted]: Message verification failed I think that CVSROOT/approvecheck needs to have some debugging until the problem is resolved. Perhaps it cannot read the $FILES_FILE for some reason, so the check is skipped, I don't know how to trigger it. Nothing looks suspicious at a glance. :-( Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --3lcZGd9BuhuYXNfi Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (FreeBSD) iD8DBQFBOYENqRfpzJluFF4RAg1WAKCbWTjxdiuHrhzhBb+QK+8NvNBXbgCdFA5t Fl4VNEfA7YDqzGARutwctio= =rPwr -----END PGP SIGNATURE----- --3lcZGd9BuhuYXNfi--