From owner-svn-ports-head@FreeBSD.ORG Thu May 14 16:08:02 2015 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3861078E for ; Thu, 14 May 2015 16:08:02 +0000 (UTC) Received: from mail-ob0-f177.google.com (mail-ob0-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 00B171ECB for ; Thu, 14 May 2015 16:08:01 +0000 (UTC) Received: by obfe9 with SMTP id e9so56376165obf.1 for ; Thu, 14 May 2015 09:08:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=F8jJoonty7jbJVrtvY0TwFl/Pb/kfkA0FqY4a3chORA=; b=WbpA4NOv6BRsYtPWjc+j+Fh4kNjK13vMKB8PJE1c7bnlPmL92F2kCEsAjNm5jLFAzI V/P694LHt7wjZDcWi5izIerL+wVf8bxx5J+0gt6ZxKX4eICB5+lDOfa0/3bu7TL1wLaS MTgyzjdgvL53CNdB1n04mcLasKxV0JVoUF0sTBtzmxtRlP9EGpuSvTt2H97YPYXbeexk 5AZLE0KAts35jKmFcwE6tncag8l//TFR8RmXFi+KvdHYuooHrbw90U87puFQknoaLymt PegSk5byEz6pT+HkCm8P49lQ0sMEFYtb7ErPnJHZakcXpMWZsb/zjJ4BaIRISo4yw3Fs fYBQ== X-Gm-Message-State: ALoCoQmodLKTDEAAL5hfFH8zL/2KkG8xFP+XfpyyqEBdKqCwY4C3Tum//ImmjH5mRZbwDUy/ZcxU X-Received: by 10.202.49.77 with SMTP id x74mr3981157oix.86.1431619681237; Thu, 14 May 2015 09:08:01 -0700 (PDT) MIME-Version: 1.0 Sender: sunpoet@sunpoet.net Received: by 10.202.174.4 with HTTP; Thu, 14 May 2015 09:07:40 -0700 (PDT) In-Reply-To: <5554C761.3060609@FreeBSD.org> References: <201505140101.t4E11r9T031351@svn.freebsd.org> <08F806A7-3CD9-417A-BA4E-AF739E83B6A8@adamw.org> <082DB80D-6385-4F4F-8A86-2DB4561E39E8@adamw.org> <5554C761.3060609@FreeBSD.org> From: Sunpoet Po-Chuan Hsieh Date: Fri, 15 May 2015 00:07:40 +0800 X-Google-Sender-Auth: c4Mdo2wmPLCWxf_eRQBITOp-fyE Message-ID: Subject: Re: svn commit: r386285 - head/security/keychain To: Bryan Drewery Cc: Adam Weinberger , "Philip M. Gollucci" , "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , "ports-committers@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 May 2015 16:08:02 -0000 On Fri, May 15, 2015 at 12:03 AM, Bryan Drewery wrote: > On 5/14/2015 11:00 AM, Adam Weinberger wrote: > >> On 13 May, 2015, at 21:20, Philip M. Gollucci > wrote: > >> > >> Then it needs an option not an if exists() > > > > Bryan, can you please consider reverting it, or giving me approval to > revert it? It may fix the case when the port is built in poudriere without > sshd in base, but it is a regression for everybody else. > > > > # Adam > > > > > > No. The way RUN_DEPENDS is supposed to work is what I said in the > commit. These exists() checks are redundant and confuse the package > dependencies. > > How are you building? It's possible the tool you are using is > incorrectly handling RUN_DEPENDS. > > -- > Regards, > Bryan Drewery > > I could confirm that keychain 2.8.0_2 will not bring in openssh-portable if you have ssh-agent in base. But 'make run-depends-list' will give you incorrect result. Regards, sunpoet % make install ===> Installing for keychain-2.8.0_2 ===> keychain-2.8.0_2 depends on file: /usr/local/bin/bash - found ===> keychain-2.8.0_2 depends on executable: ssh-agent - found ===> Checking if keychain already installed actual-package-depends: dependency on /usr/bin/ssh-agent not registered (normal if it belongs to base) ===> Registering installation for keychain-2.8.0_2 Installing keychain-2.8.0_2... % pkg info -dx keychain keychain-2.8.0_2: bash-4.3.33 % make run-depends-list /usr/ports/security/openssh-portable /usr/ports/shells/bash