From owner-svn-src-all@FreeBSD.ORG Thu Jun 11 14:22:26 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 131BE106566B; Thu, 11 Jun 2009 14:22:26 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id D7DBB8FC0A; Thu, 11 Jun 2009 14:22:25 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 74AA146B32; Thu, 11 Jun 2009 10:22:25 -0400 (EDT) Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 5046A8A06C; Thu, 11 Jun 2009 10:22:24 -0400 (EDT) From: John Baldwin To: Robert Watson Date: Wed, 10 Jun 2009 17:52:10 -0400 User-Agent: KMail/1.9.7 References: <200906101827.n5AIRFoR022115@svn.freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200906101752.11336.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Thu, 11 Jun 2009 10:22:24 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.0 required=4.2 tests=AWL,BAYES_00, DATE_IN_PAST_12_24,RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r193941 - head/sys/netinet X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jun 2009 14:22:26 -0000 On Wednesday 10 June 2009 3:52:31 pm Robert Watson wrote: > > On Wed, 10 Jun 2009, John Baldwin wrote: > > > Change a few members of tcpcb that store cached copies of ticks to be ints > > instead of unsigned longs. This fixes a few overflow edge cases on 64-bit > > platforms. Specifically, if an idle connection receives a packet shortly > > before 2^31 clock ticks of uptime (about 25 days with hz=1000) and the keep > > alive timer fires after 2^31 clock ticks, the keep alive timer will think > > that the connection has been idle for a very long time and will immediately > > drop the connection instead of sending a keep alive probe. > > > > Reviewed by: silby, gnn, lstewart > > MFC after: 1 week > > That's pretty subtle even as TCP bugs go, nice work :-). More of the credit goes to gnn@ and my co-workers. I had told gnn@ to not worry about overflow about a week ago because I had just assumed (incorrectly) that 'ticks' and 't_rcvtime' were the same size. :-/ -- John Baldwin