From owner-freebsd-net@FreeBSD.ORG  Fri Oct  5 17:50:15 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 90ED2106566C
	for <freebsd-net@hub.freebsd.org>; Fri,  5 Oct 2012 17:50:15 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 7C2A58FC0A
	for <freebsd-net@hub.freebsd.org>; Fri,  5 Oct 2012 17:50:15 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q95HoF3G087288
	for <freebsd-net@freefall.freebsd.org>; Fri, 5 Oct 2012 17:50:15 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q95HoEuo087272;
	Fri, 5 Oct 2012 17:50:14 GMT (envelope-from gnats)
Date: Fri, 5 Oct 2012 17:50:14 GMT
Message-Id: <201210051750.q95HoEuo087272@freefall.freebsd.org>
To: freebsd-net@FreeBSD.org
From: Navdeep Parhar <np@FreeBSD.org>
Cc: 
Subject: Re: kern/172364: [cxbge] cxbge_vlan_config() Fatal trap 12: page
 fault while in kernel mode
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Navdeep Parhar <np@FreeBSD.org>
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Oct 2012 17:50:15 -0000

The following reply was made to PR kern/172364; it has been noted by GNATS.

From: Navdeep Parhar <np@FreeBSD.org>
To: bug-followup@FreeBSD.org, atkin901@gmail.com
Cc:  
Subject: Re: kern/172364: [cxbge] cxbge_vlan_config() Fatal trap 12: page
 fault while in kernel mode
Date: Fri, 05 Oct 2012 10:41:56 -0700

 Here's an untested patch that you could try:
 
 diff -r 62ccc35abd89 sys/dev/cxgbe/t4_main.c
 --- a/sys/dev/cxgbe/t4_main.c	Wed Oct 03 15:57:10 2012 -0700
 +++ b/sys/dev/cxgbe/t4_main.c	Fri Oct 05 10:32:11 2012 -0700
 @@ -2995,7 +2995,7 @@
   {
   	struct ifnet *vlan;
 
 -	if (arg != ifp)
 +	if (arg != ifp || ifp->if_type != IFT_ETHER)
   		return;
 
   	vlan = VLAN_DEVAT(ifp, vid);
 
 
 By the way, I noticed your kernel name is CXGBETOE.  Keep in mind that 
 hw TCP offload over an if_lagg is unimplemented as of now.  TCP offload 
 over an if_vlan directly over cxgbe will work just fine.
 
 Regards,
 Navdeep