Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 12 Dec 2024 12:58:57 +0100
From:      Piotr Kubaj <pkubaj@anongoth.pl>
To:        Yuri Victorovich <yuri@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: 71c6c33462ac - main - science/PETSc: Fix build on 32-bit systems
Message-ID:  <Z1rQARytsr25iD9x@KGPE-D16>
In-Reply-To: <202412121133.4BCBXZb5048026@gitrepo.freebsd.org>
References:  <202412121133.4BCBXZb5048026@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--24AHUYAhTmQo2q3o
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

This is wrong. E.g. on powerpc64:
pkubaj@talos-powerpc64:$/usr/ports$ uname -m
powerpc
pkubaj@talos-powerpc64:$/usr/ports$ uname -p=20
powerpc64

Why not just use ${ARCH}?

On 24-12-12 11:33:35, Yuri Victorovich wrote:
> The branch main has been updated by yuri:
>=20
> URL: https://cgit.FreeBSD.org/ports/commit/?id=3D71c6c33462ac1b7994689da0=
6156f31577fcb774
>=20
> commit 71c6c33462ac1b7994689da06156f31577fcb774
> Author:     Yuri Victorovich <yuri@FreeBSD.org>
> AuthorDate: 2024-12-12 11:32:44 +0000
> Commit:     Yuri Victorovich <yuri@FreeBSD.org>
> CommitDate: 2024-12-12 11:32:44 +0000
>=20
>     science/PETSc: Fix build on 32-bit systems
>    =20
>     ... by matching index size with math/metis
>    =20
>     Reported by:    fallout
> ---
>  science/PETSc/Makefile | 5 +++++
>  1 file changed, 5 insertions(+)
>=20
> diff --git a/science/PETSc/Makefile b/science/PETSc/Makefile
> index 160a0029091d..1da1a7f92aec 100644
> --- a/science/PETSc/Makefile
> +++ b/science/PETSc/Makefile
> @@ -1,5 +1,6 @@
>  PORTNAME=3D	PETSc
>  DISTVERSION=3D	3.22.1
> +PORTREVISION=3D	1
>  CATEGORIES=3D	science devel
>  MASTER_SITES=3D	https://web.cels.anl.gov/projects/petsc/download/release=
-snapshots/
>  DISTNAME=3D	${PORTNAME:tl}-${DISTVERSION}
> @@ -21,6 +22,8 @@ USE_XORG=3D	x11
>  SHEBANG_FILES=3D	configure lib/petsc/bin/*.py lib/petsc/bin/saws/SAWs.py=
 lib/petsc/bin/saws/*.bash config/*.py	\
>  		lib/petsc/bin/petscnagfor share/petsc/chkerrconvert.py
> =20
> +XARCH!=3D		uname -m
> +
>  GNU_CONFIGURE=3D	yes
>  CONFIGURE_LOG=3D	configure.log
>  CONFIGURE_ARGS=3D	--with-shared-libraries=3D1 \
> @@ -32,7 +35,9 @@ CONFIGURE_ARGS=3D	--with-shared-libraries=3D1 \
>  		MAKEFLAGS=3D"${MAKEFLAGS}" LDFLAGS=3D"${LDFLAGS}" LIBS=3D""
>  CONFIGURE_ARGS_amd64=3D	CFLAGS=3D"${CFLAGS} -msse2" CXXFLAGS=3D"${CXXFLA=
GS} -msse2"
>  CONFIGURE_ARGS_i386=3D	CFLAGS=3D"${CFLAGS} -msse2" CXXFLAGS=3D"${CXXFLAG=
S} -msse2"
> +.if ${XARCH:M*64*} # match IDXTYPEWIDTH being set to 64 in math/metis
>  CONFIGURE_ARGS+=3D	--with-64-bit-indices # as opposed to 32-bit indices =
that are default
> +.endif
> =20
>  MAKEFILE=3D	makefile
>  TEST_TARGET=3D	test # 152 of 11396 tests (1.3%) fail due to missing file=
s like /usr/local/share/petsc/datafiles/meshes/square_periodic.msh (tests e=
xpect the packe to be installed)

--24AHUYAhTmQo2q3o
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmda0AEACgkQelmbhSCD
nJ04Og/9G4zIG/k2btvOEuO18cFOLedMZAPHguND7Nj9RA5a+NgSoRmjm2HXw5vP
vnWWAh8aqUrC7XpmMsZHRek99puNlC8aCCeAkO1ZAwLnGKlApA5eJDXSZiTsHFeW
pamf5WeOqeU5C8o3sKFOqgaLHow6d1g2eXQ7aPVCP0FzeVhfYnbOx5+9LRwkFdTa
wuZBl6qIArNNQffB9rUbHUDBSZG9MYv1oP8kWgenLlLGbgOGHdr/tW1f0MRpkk/E
akNyRE01ZtTDAchvdNk/OEz+43ICMGRglTthhVgzrozK/V0lbg5bUhxQsKl1tJ1W
DSqsgXJ0nkxI4i2021VwI2xTyXHg28r3WclK8TUGpuoHdXWIkfDyAJHvB90docqt
kolOcLHnpIKIPwl4pRb0qIpWoUHTq6q1oeKvbq1wYZ5PwJnOlp0RDGi1MX09Kayh
t+Uwheur/2hCYpUG2yC9PkwG8gLfo2jbwGu21fKtkfxnSfUX8YBRfpIGOErT+GMk
GtY2MzeVgZ8qAuG8j/4sXObkzO1X+tVSYQng85VdqPcnRJNyt1aD0JmROYKjA0ch
mXvgIxQIHHhNySXkbTlBXUTvBoLOlRxYgAO+llTCdBX9F2QvrRSu8YSG2cqRFqm6
Ilgg5QmBoiHXjJgAnUyVeZutE1V7D81DS90lqLjzn8nxlYzjZew=
=1HTO
-----END PGP SIGNATURE-----

--24AHUYAhTmQo2q3o--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Z1rQARytsr25iD9x>