From owner-freebsd-fs@freebsd.org Sat Nov 17 01:43:45 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 39F99110C8DE for ; Sat, 17 Nov 2018 01:43:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id C0F907411C for ; Sat, 17 Nov 2018 01:43:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 80896110C8D2; Sat, 17 Nov 2018 01:43:44 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5C025110C8D1 for ; Sat, 17 Nov 2018 01:43:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EBB297411A for ; Sat, 17 Nov 2018 01:43:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 09C47EC90 for ; Sat, 17 Nov 2018 01:43:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wAH1hgBU093684 for ; Sat, 17 Nov 2018 01:43:42 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wAH1hg8c093683 for fs@FreeBSD.org; Sat, 17 Nov 2018 01:43:42 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 233245] [UFS] [enhancement] Softupdates fails to track dependency between appended data and i_size Date: Sat, 17 Nov 2018 01:43:41 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: mckusick@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Rspamd-Queue-Id: C0F907411C X-Spamd-Result: default: False [0.70 / 15.00]; ASN(0.00)[asn:10310, ipnet:2001:1900:2254::/48, country:US]; local_wl_from(0.00)[freebsd.org]; NEURAL_SPAM_SHORT(0.70)[0.701,0] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Nov 2018 01:43:45 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233245 --- Comment #6 from Kirk McKusick --- (In reply to Conrad Meyer from comment #5) > I would be happy to assign it to myself to take it off the fs@ list, if t= hat > seems most reasonable to everybody. I have no objection to it being on the fs@ list. That way I see any dialog = that happens on it. But if you decide to take it off the fs@ list, then please a= dd me explicitly. > Do you know of any additional good resources I can read for the specific > dependency graph behavior / rollback semantics of SU? I have the FreeBSD > D&I 2e book of course, and the source code is the final word. But if you > have any additional references you can share, I would appreciate it. In about 2000 I used the `special topics' lecture of my advanced code readi= ng class to do a walk-through of the soft updates code. It is a 2.5 hour video= of me going through softdep.h and ffs_softdep.c. It predates the addition of t= he journaling support, so reflects a simpler time, but is probably still usefu= l to get a general understanding. I would be willing to make the video available= to you if you want to watch it. > (Tangential to this enhancement, I might take a pass cleaning up the plain > English of the ffs_softdep.c comment blocks. They are thorough, but tend= to > lack visual separation and thus do not scan easily. Additionally, some > references to specific objects are quoted, while others are not. It might > help me understand SU better to do a pass making an attempt to help others > understand SU better. :-)) I believe that commenting code is very important and have tried to do a good job of it in the soft updates code. So I strongly encourage you to work to improve it. Often the original author overlooks things that seem obvious to them but in fact are confusing to those that are not intimately familiar wi= th the code. So filling in those gaps is a valuable addition. --=20 You are receiving this mail because: You are the assignee for the bug.=