From owner-cvs-all@FreeBSD.ORG  Sat Apr 14 22:12:23 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@freebsd.org
Delivered-To: cvs-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 02A1016A404; Sat, 14 Apr 2007 22:12:23 +0000 (UTC)
Date: Sat, 14 Apr 2007 22:12:22 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Stanislav Sedov <stas@FreeBSD.org>
Message-ID: <20070414221222.GA83055@FreeBSD.org>
References: <200704142021.l3EKLwT6071007@repoman.freebsd.org>
	<cb5206420704141359g3f7f44f2m4cfb54010369ec34@mail.gmail.com>
	<20070415011545.d25b8107.stas@FreeBSD.org>
	<cb5206420704141428n551a5228i186c931714c9ba@mail.gmail.com>
	<20070415020616.df924d69.stas@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <20070415020616.df924d69.stas@FreeBSD.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-ports@freebsd.org, Andrew Pantyukhin <infofarmer@FreeBSD.org>,
	cvs-all@freebsd.org, ports-committers@freebsd.org
Subject: Re: cvs commit: ports/www Makefile ports/www/xpi-vimperator
	Makefile distinfo pkg-descr
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Apr 2007 22:12:23 -0000

On Sun, Apr 15, 2007 at 02:06:16AM +0400, Stanislav Sedov wrote:
> On Sun, 15 Apr 2007 01:28:36 +0400
> "Andrew Pantyukhin" <infofarmer@FreeBSD.org> mentioned:
> > >
> > > Yeah, i was amazingly glad to discover it:-)
> > >
> > > > -MASTER_SITES=  ${MASTER_SITE_MOZDEV}
> > > > -MASTER_SITE_SUBDIR=    ${PORTNAME}
> > > > -DISTNAME=      ${PORTNAME}_${PORTVERSION}
> > > > +MASTER_SITES=  MOZDEV
> > > > +DISTNAME=      ${PORTNAME}_${DISTVERSION}
> > >
> > > Hmm. Why use ${DISTVERSION} instead of PORTVERSION?
> >
> > grep '^DISTNAME' /usr/ports/Mk/bsd.port.mk
> >
> 
> Thanks for explanation, I obviously was not informed about this file;-)
> Seriously, I see no reason to use ${DISTVERSION} instead of
> PORTVERSION,  and you didn't give one.

In most cases, it's a noop.  However, DISTVERSION is more generic, since
it takes care of beta/rc/pre affixes for you (i.e. yields correct
PORTVERSION which should pass pkg_version -t test when updating to final
release).

./danfe