Date: Sat, 2 Feb 2008 19:31:38 +0100 From: Olivier Houchard <mlfbsd@ci0.org> To: Soeren Straarup <xride@x12.dk> Cc: arm@freebsd.org Subject: Re: about src/lib/libkse/arch/arm/include/pthread_md.h Message-ID: <20080202183138.GA17602@ci0.org> In-Reply-To: <20080202090238.289eeb66@x12.dk> References: <20080202090238.289eeb66@x12.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Soeren,
On Sat, Feb 02, 2008 at 09:02:38AM +0100, Soeren Straarup wrote:
> Hi,
>
> Index: pthread_md.h
> ===================================================================
> RCS file: /home/ncvs/src/lib/libkse/arch/arm/include/pthread_md.h,v
> retrieving revision 1.9
> diff -u -r1.9 pthread_md.h
> --- pthread_md.h 9 Oct 2007 13:42:23 -0000 1.9
> +++ pthread_md.h 1 Feb 2008 22:48:50 -0000
> @@ -240,7 +240,7 @@
> tcb->tcb_tmbx.tm_lwp = kcb->kcb_kmbx.km_lwp;
> if (setmbox)
> _thr_setcontext(mc, (intptr_t)&tcb->tcb_tmbx,
> - (intptr_t
> *)&kcb->kcb_kmbx.km_curthread);
> + (intptr_t *)kcb->kcb_kmbx.km_curthread);
> else
> _thr_setcontext(mc, 0, NULL);
> } else {
>
>
> Is that change correct?
>
If I'm nor wrong, the original code is right, and that's what the other
platforms seem to do so. Why do you think it should be changed ?
Regards,
Olivier
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080202183138.GA17602>