Date: Mon, 5 Sep 2022 23:59:14 +0300 From: Dmitry Marakasov <amdmi3@amdmi3.ru> To: Dima Panov <fluffy@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, portmgr@freebsd.org Subject: Re: git: e4e5c966bbc8 - main - x11/rsibreak: pet stage-qa Message-ID: <YxZjImeepTd4j67P@hades.panopticon> In-Reply-To: <202209051913.285JDJ7J030927@gitrepo.freebsd.org> References: <202209051913.285JDJ7J030927@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* Dima Panov (fluffy@FreeBSD.org) wrote:
> commit e4e5c966bbc889b90e79f1745d523b14e6590798
> Author: Dima Panov <fluffy@FreeBSD.org>
> AuthorDate: 2022-09-05 19:05:22 +0000
> Commit: Dima Panov <fluffy@FreeBSD.org>
> CommitDate: 2022-09-05 19:07:11 +0000
>
> x11/rsibreak: pet stage-qa
(Replying to random commit)
Note that most of these are most likely incorrect: dependencies
should only list what is explicitly used by the port, while here
in most cases you list transitive dependencies brought in by, for
instance, some Qt components. This is erroneous, as they have in
fact nothing to do with the leaf ports. A possible solution which
shuts up stage-qa false positives and does not pollute ports with
unrelated depends would be to bring these implicitly through the
framework, as, for instance, *_USE_GNOME_IMPL does in Uses/gnome.mk
> x11/rsibreak/Makefile | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/x11/rsibreak/Makefile b/x11/rsibreak/Makefile
> index 71d28bbe9a20..ba4e8fcace5e 100644
> --- a/x11/rsibreak/Makefile
> +++ b/x11/rsibreak/Makefile
> @@ -1,5 +1,6 @@
> PORTNAME= rsibreak
> DISTVERSION= 0.12.15
> +PORTREVISION= 1
> CATEGORIES= x11 kde
> MASTER_SITES= KDE/stable/${PORTNAME}/${PORTVERSION:R}/
>
> @@ -9,10 +10,11 @@ COMMENT= KDE RSI prevention tool
> LICENSE= GPLv2+
> LICENSE_FILE= ${WRKSRC}/LICENSES/GPL-2.0-or-later.txt
>
> -USES= cmake compiler:c++11-lang gettext kde:5 qt:5 tar:xz
> +USES= cmake compiler:c++11-lang gettext kde:5 qt:5 tar:xz xorg
> USE_KDE= auth codecs config configwidgets coreaddons crash dbusaddons doctools ecm \
> iconthemes i18n idletime notifications notifyconfig \
> sonnet textwidgets xmlgui widgetsaddons windowsystem
> USE_QT= core dbus gui widgets xml buildtools_build qmake_build
> +USE_XORG= x11
>
> .include <bsd.port.mk>
>
--
Dmitry Marakasov .
amdmi3@amdmi3.ru ..: https://github.com/AMDmi3 https://amdmi3.ru/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YxZjImeepTd4j67P>