From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Oct 13 20:00:40 2005 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5A31516A422 for ; Thu, 13 Oct 2005 20:00:40 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 18DC443D6B for ; Thu, 13 Oct 2005 20:00:37 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j9DK0aCI047871 for ; Thu, 13 Oct 2005 20:00:36 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j9DK0asj047870; Thu, 13 Oct 2005 20:00:36 GMT (envelope-from gnats) Date: Thu, 13 Oct 2005 20:00:36 GMT Message-Id: <200510132000.j9DK0asj047870@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: =?ISO-8859-2?Q?Zahemszky_G=E1bor?= Cc: Subject: Re: ports/87397: incorrect use of PAPERSIZE make variable in some ports X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: =?ISO-8859-2?Q?Zahemszky_G=E1bor?= List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Oct 2005 20:00:40 -0000 The following reply was made to PR ports/87397; it has been noted by GNATS. From: =?ISO-8859-2?Q?Zahemszky_G=E1bor?= To: bug-followup@FreeBSD.org, gabor@Zahemszky.HU Cc: Subject: Re: ports/87397: incorrect use of PAPERSIZE make variable in some ports Date: Thu, 13 Oct 2005 21:53:05 +0200 Opps, I've just found, that there are some other ports with paper size settings. math/R: it has a LETTER_PAPER option, and the next piece of code: .if defined(WITH_LETTER_PAPER) CONFIGURE_ENV+= R_PAPERSIZE=letter .endif I think, it would be better to use the "global" PAPERSIZE variable as in: .if ( defined( PAPERSIZE ) && ( ${PAPERSIZE} == "letter" ) || ( ${PAPERSIZE} == "letterdj" ) ) CONFIGURE_ENV+= R_PAPERSIZE=letter .endif There are another ports: teTeX, dvipsk-tetex and xdvik with this: .if defined(WITH_LETTERSIZE) FLAVOR+= letter DEPENDS_ARGS+= WITH_LETTERSIZE=true PAPERSIZE= letter .else PAPERSIZE= a4 .endif It may use this form: .if ( defined( PAPERSIZE ) && ( ${PAPERSIZE} == "letter" || ${PAPERSIZE} == "letterdj" ) ) FLAVOR+= letter DEPENDS_ARGS+= WITH_LETTERSIZE=true PAPERSIZE= letter .else PAPERSIZE= a4 .endif by, Gabor -- #!/bin/ksh Z='21N16I25C25E30, 40M30E33E25T15U!';IFS=' ABCDEFGHIJKLMNOPQRSTUVWXYZ ';set -- $Z;for i;{ [[ $i = ? ]]&&print $i&&break;[[ $i = ??? ]]&&j=$i&&i=${i%?};typeset -i40 i=8#$i;print -n ${i#???};[[ "$j" = ??? ]]&&print -n "${j#??} "&&j=;typeset +i i;};IFS=' 0123456789 ';set -- $Z;for i;{ [[ $i = , ]]&&i=2;[[ $i = ?? ]]||typeset -l i;j="$j $i";typeset +l i;};print "$j"