From owner-freebsd-ports@freebsd.org Tue Jan 5 08:38:20 2016 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C58BAA564C1 for ; Tue, 5 Jan 2016 08:38:20 +0000 (UTC) (envelope-from matthew@FreeBSD.org) Received: from smtp.infracaninophile.co.uk (smtp.infracaninophile.co.uk [IPv6:2001:8b0:151:1:3cd3:cd67:fafa:3d78]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.infracaninophile.co.uk", Issuer "infracaninophile.co.uk" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F35B15F7 for ; Tue, 5 Jan 2016 08:38:20 +0000 (UTC) (envelope-from matthew@FreeBSD.org) Received: from liminal.local (liminal.infracaninophile.co.uk [IPv6:2001:8b0:151:1:3636:3bff:fed4:b0d6]) (authenticated bits=0) by smtp.infracaninophile.co.uk (8.15.2/8.15.2) with ESMTPSA id u058cExp058207 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Tue, 5 Jan 2016 08:38:14 GMT (envelope-from matthew@FreeBSD.org) Authentication-Results: smtp.infracaninophile.co.uk; dmarc=none header.from=FreeBSD.org DKIM-Filter: OpenDKIM Filter v2.10.3 smtp.infracaninophile.co.uk u058cExp058207 Authentication-Results: smtp.infracaninophile.co.uk/u058cExp058207; dkim=none; dkim-atps=neutral X-Authentication-Warning: lucid-nonsense.infracaninophile.co.uk: Host liminal.infracaninophile.co.uk [IPv6:2001:8b0:151:1:3636:3bff:fed4:b0d6] claimed to be liminal.local To: freebsd-ports@freebsd.org From: Matthew Seaman Subject: Review requested -- new trac plugin port X-Enigmail-Draft-Status: N1110 Message-ID: <568B80EF.2000409@FreeBSD.org> Date: Tue, 5 Jan 2016 08:38:07 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Ke3IpIVtI5arek9lrWcmugjwAuihOK4vq" X-Virus-Scanned: clamav-milter 0.99 at lucid-nonsense.infracaninophile.co.uk X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on lucid-nonsense.infracaninophile.co.uk X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jan 2016 08:38:21 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Ke3IpIVtI5arek9lrWcmugjwAuihOK4vq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Dear all, Before hitting the commit button on this, I thought I'd check that what I'm doing here is OK. So far I've got three new trac plugin modules I'd like to port. They're all pretty similar, and I've based my work on some existing trac plugin ports (mostly www/trac-discussion). However it doesn't really feel right to me. I've created a review for the first of these -- https://reviews.freebsd.org/D4796 The others are essentially the same pattern, but they aren't anything near finished quality yet... The problem I have with this is not having some downloadable tarball to work with. Instead, I'm checking sources out of the trac-hacks SVN and rolling my own .tar.gz which I then place into MASTER_SITES=3DLOCAL/matth= ew Is this OK? Cheers, Matthew --Ke3IpIVtI5arek9lrWcmugjwAuihOK4vq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2 iQJ8BAEBCgBmBQJWi4D2XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2NTNBNjhCOTEzQTRFNkNGM0UxRTEzMjZC QjIzQUY1MThFMUE0MDEzAAoJELsjr1GOGkATahsP/2+SPxnzCKErClHgNvUo/iv4 85uUzTAFkL8mENepDkchgx6dNFvb21RIawp1rXLwN81XPfxnQP05G7TVnG8fdfiR lYqa9Int/05yXlGOvCHmrvvolg0ANyXdegFkpxbXD3G590/03cPlHbFbhSiZo5q3 Zuf7mADmgFHGeNmpgqyv7Cavt1SeTsjucqmSAPxRdo+RHKU44xgkFM2EvtB+jHFK JiTypUw/MtHBM9tmMz22QjyqHgCJiOMpXtldS31BOxNvv+cY/5b1XXOqnAOw/phy nJDvTSA8VUBOH1J+GZpO4/10CGQRcw6ytg97st14ypIUw/p4yNB3asm8jia0x2x5 GqEJVE3kRu92HDNOhwOlIbJog46bXQLHd+4vFVTracrEb4xZdpDBt2bM0ss9J+hr vp5hgKacx96YduH8Svsnc4r5JQSLGtHceXZsov54svQvqjbfIq+cDupPM0dp7KJl UjEKldBSemnZP50yPxLbbfhbdKG+CqmwIW1FqAOEV2I6Vs4ZH/FoJWRwEZBLP00J /3tmUYymSLSYSgbVwWkYRT5vFzF5b7XBWwZmHc3tff6oJsTCkfZFUnWFOKPIetmn 3CFxgC6UN8u01DxccqmvzJ4IgnnEPR9exORUW8CHlTw7bxu0v5sT3PnWCn05D4SZ y7aeWAWbW5J6qyltbF4Y =vosx -----END PGP SIGNATURE----- --Ke3IpIVtI5arek9lrWcmugjwAuihOK4vq--