From owner-cvs-all@FreeBSD.ORG Mon Mar 15 20:08:16 2010 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D2900106566B; Mon, 15 Mar 2010 20:08:16 +0000 (UTC) (envelope-from decke@bluelife.at) Received: from mail.itac.at (mail.itac.at [91.205.172.9]) by mx1.freebsd.org (Postfix) with ESMTP id 468498FC19; Mon, 15 Mar 2010 20:08:15 +0000 (UTC) Received: from [91.205.172.21] (helo=webmail.bluelife.at) by mail.itac.at with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1NrGaD-0001w6-Uh; Mon, 15 Mar 2010 21:08:14 +0100 MIME-Version: 1.0 Date: Mon, 15 Mar 2010 21:08:14 +0100 From: Bernhard Froehlich To: Doug Barton In-Reply-To: <4B9D51D7.6000005@FreeBSD.org> References: <201003140407.o2E47fhJ063684@repoman.freebsd.org> <4B9C6C9E.3070902@FreeBSD.org> <1268589378.8345.2.camel@Nokia-N900-42-11> <4B9D45C4.3090608@FreeBSD.org> <1268600188.8515.3.camel@Nokia-N900-42-11> <4B9D51D7.6000005@FreeBSD.org> Message-ID: <04cb051285628e4165973e6e1ca5bbf9@bluelife.at> X-Sender: decke@bluelife.at User-Agent: RoundCube Webmail/0.3.1 Content-Type: multipart/mixed; boundary="=_158c3564885d406d9c409038aa6c02bc" X-Spam-Score: 1.0 (+) X-Spam-Report: Spam detection software, running on the system "mail.itac.at", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Sun, 14 Mar 2010 14:15:03 -0700, Doug Barton wrote: > On 03/14/10 13:56, Bernhard Fröhlich wrote: >> Thanks for the patch! At the moment i do not have a possibility to >> double check them but the changes look good to me so please feel free to >> commit them. > > Ok, done. Thanks for the quick responses. :) [...] Content analysis details: (1.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.4 ALL_TRUSTED Passed through trusted hosts only via SMTP 3.4 FH_DATE_PAST_20XX The date is grossly in the future. -1.0 AWL AWL: From: address is in the auto white-list Cc: cvs-ports@FreeBSD.org, Wesley Shields , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: Aw: Re: Aw: Re: cvs commit: ports/www/redmine Makefile ports/www/redmine/files redmine.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Mar 2010 20:08:17 -0000 --=_158c3564885d406d9c409038aa6c02bc Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 On Sun, 14 Mar 2010 14:15:03 -0700, Doug Barton wrote: > On 03/14/10 13:56, Bernhard Fröhlich wrote: >> Thanks for the patch! At the moment i do not have a possibility to >> double check them but the changes look good to me so please feel free to >> commit them. > > Ok, done. Thanks for the quick responses. :) I found a problem with the commit yesterday. It's true that _flags is automatically append but only to "command" and not "start_cmd" so it does not work as it is now. So for testing I changed "start_cmd" to "command=/usr/local/bin/thin" and set "command_interpreter=%%PREFIX%%/bin/ruby18" and it started okay but rc.subr did not find the running binary. I investigated a little bit more and found that rc.subr:_find_processes searched for "ruby18: /usr/local/bin/thin" but the ps there only reported this: vs1# /bin/ps -ww -o pid= -o jid= -o command= -p 21778 21778 0 ruby18: thin server (0.0.0.0:3000) (ruby18) so it expects "thin" with his full path and therefor it does not find it. So changing command to "command=thin" does work and proves the theory vs1# /usr/local/etc/rc.d/redmine status /usr/local/etc/rc.d/redmine: WARNING: cannot read shebang line from thin redmine is running as pid 22176. but it breaks startup so it is no solution either. Okay that is the hard but correct way but I don't see a working solution at the moment so I propose the attached patch. This leaves everything as it is so command=%%RUBY_NAME%% to make _find_processes happy and use start_cmd with manually appending redmine_flags. If someone has a better solution i would like to know. Otherwise i would be happy if someone could commit the attached patch. Thanks! -- Bernhard Fröhlich http://www.bluelife.at/ --=_158c3564885d406d9c409038aa6c02bc Content-Transfer-Encoding: base64 Content-Type: application/octet-stream; charset=UTF-8; name=redmine.in.patch; Content-Disposition: attachment; filename=redmine.in.patch; LS0tIHJlZG1pbmUuaW4ub3JpZwkyMDEwLTAzLTE1IDE5OjQ3OjIzLjAwMDAwMDAwMCArMDEwMAor KysgcmVkbWluZS5pbgkyMDEwLTAzLTE1IDE5OjU0OjM2LjAwMDAwMDAwMCArMDEwMApAQCAtMjgs NiArMjgsNiBAQAogOiAke3JlZG1pbmVfZmxhZ3M9Ii1hIDAuMC4wLjAgLXAgMzAwMCAtZSBwcm9k dWN0aW9uIn0KIAogY29tbWFuZF9hcmdzPSItZCAtRCAtYyAlJVdXV0RJUiUlIC11IHd3dyAtZyB3 d3ciCi1zdGFydF9jbWQ9IiUlUFJFRklYJSUvYmluL3RoaW4gJHtjb21tYW5kX2FyZ3N9IHN0YXJ0 Igorc3RhcnRfY21kPSIlJVBSRUZJWCUlL2Jpbi90aGluICR7Y29tbWFuZF9hcmdzfSAke3JlZG1p bmVfZmxhZ3N9IHN0YXJ0IgogCiBydW5fcmNfY29tbWFuZCAiJDEiCg== --=_158c3564885d406d9c409038aa6c02bc--