From owner-freebsd-current@freebsd.org Thu Oct 22 05:55:13 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5CB4643EECC for ; Thu, 22 Oct 2020 05:55:13 +0000 (UTC) (envelope-from m.e.sanliturk@gmail.com) Received: from mail-oo1-xc31.google.com (mail-oo1-xc31.google.com [IPv6:2607:f8b0:4864:20::c31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CGxR44DLXz4NcS for ; Thu, 22 Oct 2020 05:55:12 +0000 (UTC) (envelope-from m.e.sanliturk@gmail.com) Received: by mail-oo1-xc31.google.com with SMTP id c10so84154oon.6 for ; Wed, 21 Oct 2020 22:55:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sDxNr3yIJQgKHACYwXWdUYtQq/1XyH29+406rjwtRcY=; b=Vn7/L1fqBzFhePWgmlCmdnPaVnvqm51KKOEBnlhH1Afgti300Cwl8W0t0+Zcy3DKsx NkBP1HYqBPw2b0RCkuVF+exL2FGYhKvYOn+JuLVWd9rAGTIdf80h5GvWXqS8v8ubxLqY cwOwThIyvcpoa76faNtA7fxreYyuJObfDxuGem5VFpVhip9SsYR5DYv8aGdgllgxV7LH Ylt9mI0h9ZQzvWKQwNmpLhSF3R9Ln6R2Z76jL4DL+1Bfe28b8X+/2siDL69PH4HRNsu5 ivb2QN7LTRnMpJNY6zTffjodgdSLswX47jgoftvdfCUCmsuBBSyvR6GeYVj/nQXQlihX VM7A== X-Gm-Message-State: AOAM531KyOHNR61Cy3YQwDtKEdgXMbdGTouz6bdWqpCjtadTZTbxylW4 GlcB0smfywpXCCLENi1R97Wea/e4jhvkxEXsEQU= X-Google-Smtp-Source: ABdhPJwo8M6GCfdfThPb7JkGCD7uRKQDwjLgal2DQDOsm8fVTpupv1Dslqwsj+IYnPXA74sFf+eHWyvde+ib2+iWAqE= X-Received: by 2002:a4a:b78f:: with SMTP id a15mr803383oop.33.1603346111230; Wed, 21 Oct 2020 22:55:11 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Mehmet Erol Sanliturk Date: Thu, 22 Oct 2020 08:54:33 +0300 Message-ID: Subject: Re: copyright notice question To: Rick Macklem Cc: Warner Losh , "freebsd-current@FreeBSD.org" X-Rspamd-Queue-Id: 4CGxR44DLXz4NcS X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.06 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-1.03)[-1.034]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.02)[-1.015]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.01)[-1.009]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::c31:from]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-current] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Oct 2020 05:55:13 -0000 On Thu, Oct 22, 2020 at 2:52 AM Rick Macklem wrote: > Mehmet Erol Sanliturk wrote: > >On Wed, Oct 21, 2020 at 4:04 AM Rick Macklem > wrote: > >>Warner Losh wrote: > >>>On Mon, Oct 19, 2020, 7:25 PM Rick Macklem rmacklem@uoguelph.ca>>> wrote: > >>>>I'll admit I've hesitated to ask this for a long time, but I guess I > have to;-) > >>>>I've created two daemons for NFS-over-TLS, using the code in > >>>>/usr/src/usr.sbin/gssd/gssd.c as a starting point. > >>>>--> As such, I left the copyright notice from this file on the two > files. > >>>> (As you can see, it is a 2 clause FreeBSD one, so the terms > aren't > >>>> an issue.) > >>>> > >>>>What I am wondering is if I should be adding my name to it as an > >>>>additional author or something like that? > >>>>(I don't care, but it does seem a little weird that the copyright is > held > >>>> by Isilon Inc, since I have no connection to them.) > >>> > >>>Likely. If you changed a substantial amount, then yes. The rule of > thumb is >50% > >>> is no brainer yes. Smaller percentages require more nuanced judgement > as to whether the changes are substantial enough to create a new work. > Chances are > >>> quite good you fall into one of those categories. Also, if you have > replaced more > >>>than ~90% chances are good no original work remains. Again, a judgement > call. > >>>There are more technical legal guidelines, but that would require a > lawyer. > >>> > >>>My hunch is that unless this is something far more trivial than I then > I'd add the > >>> notice, but retaining the old. > >>Well, I'd guess it's somewhere in the 50->90% category. > >>Would just adding a comment below the current copyright notice like: > >>/* > >> * Extensively modified from /usr/src/usr.sbin/gssd.c for RPC-over-TLS > >> * by Rick Macklem. > >> */ > >>be sufficient for the project, or should I put a second copyright notice > >>on it with my name on it? (This will seem odd, since it will have the > same > >>terms as the extant one, but if that is what is appropriate for the > project..) > >> > >>It is my understanding (I'm obviously not a lawyer, clearly indicated by > the > >>size of my bank account;-) that a copyright notice can only be changed by > >>the holder (or with their express permission), but an additional > copyright > >>notice can be attached to the work to cover the re-write. > >>Is this correct? (All amateur lawyers, feel free to respond;-) > >> > >>Thanks for your comments, rick > >> > >>>Warnet > >> > [copyright comment snipped] > >My opinion is as follows : > > > >At the top of the related sources I would include a message ( > approximately ) as >follows : > > I believe for FreeBSD this would need to be after the main copyright > notice, > but that is trivial, I think? > > > A "Copyright owner additions Style Guide" may be prepared by the FreeBSD Project to make a common application pattern for such inclusions . A commonly accepted and applied style is the best over time . > >After svn ( or git ) modification number(s) ... ( including ) I have > made substantial ( or significant ) modifications ( or improvements ) . > >The copyright of these modifications with the present license listed > below are >belong to > > > >Rick Macklem , starting from date ..... > > ( Rick Macklem ... an approximately fixed address ... ) > Does anyone know if there are examples of this in other major open > source projects? > > I would be very shy of creating a notice that is not exactly what other > FreeBSD files have in them. For one thing, is referring to license terms > in another > copyright notice "standard practice"? > > I'll admit that, unless there are examples of this elsewhere in the FreeBSD > source tree (or at least in other major open source projects), I would not > be > comfortable doing this. > > Maybe I'll try asking this question... > Is there a concern that the copyright notice that is on gssd.c could be > considered > "not valid" due to the extensive changes made to the code by me? > (If the answer to that is "no", then I don't see that anything needs to be > done, > since the notice includes reasonable terms as already used elsewhere in > FreeBSD. > I have no interest in being a copyright holder for this unless the > copyright can > be invalidated.) > Put another way, "Is there a concern that the extensive changes would > allow the > copyright notice be replaced by something like a GPL ?". > > rick, who would rather just lease the notice alone > > Please consider zLib License : https://en.wikipedia.org/wiki/Zlib_License zlib License Inclusion of such modification information into modified sources is compulsory . One point is obvious : Modifications into a previously copyrighted source ( work ) either does NOT invalidate the previous copyright of the work or can NOT change its license . New additions may be included by a separate license , for example GPL , but the new license is applicable only to the NEW additions . I will not remember such an example , but , surely I can say that I am seeing many sources with such modification licenses , because I am tracking a large number of software repositories or I am encountering such sources during my open source software searches . No one is obliged to accept or use such sources because any one may use/start original licensed sources . My suggestion to include SVN ( or GIT ) number(s) is to eliminate searches to find copyright affected first copy . > > Each contributor may append such notifications listed on the topmost part . > When a person reads such sources , she/he very easily understands its > modification and copyright status without any doubt . > > > Mehmet Erol Sanliturk > > > > > > > >