From owner-svn-ports-all@freebsd.org  Fri Dec 29 14:35:23 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 54D77E8E8E2;
 Fri, 29 Dec 2017 14:35:23 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 364196C039;
 Fri, 29 Dec 2017 14:35:23 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 75C7819E62; Fri, 29 Dec 2017 14:35:22 +0000 (UTC)
Date: Fri, 29 Dec 2017 14:35:22 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Luca Pizzamiglio <pizzamig@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r457507 - head/science/lamprop
Message-ID: <20171229143522.GA39495@FreeBSD.org>
References: <201712291425.vBTEPGj0051945@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201712291425.vBTEPGj0051945@repo.freebsd.org>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Dec 2017 14:35:23 -0000

On Fri, Dec 29, 2017 at 02:25:16PM +0000, Luca Pizzamiglio wrote:
> New Revision: 457507
> URL: https://svnweb.freebsd.org/changeset/ports/457507
> 
> Log:
>   science/lamprop: Update to 3.4
>   
>   PR:		221544
>   Submitted by:	rsmith@xs4all.nl (maintainer)
> 
> Modified: head/science/lamprop/Makefile
> ...
> +PORTVERSION=	3.4
> +CATEGORIES=	science python
> +MASTER_SITES=	GH

What is the point of setting MASTER_SITES now that it was converted to
USE_GITHUB?

>  do-install:
> -	cd ${WRKSRC} && ${MAKE} PREFIX=${STAGEDIR}${PREFIX} install
> +	${INSTALL_SCRIPT} ${WRKSRC}/lamprop ${STAGEDIR}${PREFIX}/bin
> +	${INSTALL_MAN} ${WRKSRC}/doc/lamprop.1 ${STAGEDIR}${MAN1PREFIX}/man/man1
> +	${INSTALL_MAN} ${WRKSRC}/doc/lamprop.5 ${STAGEDIR}${MAN5PREFIX}/man/man5

Since maintainer is apparently also the author, could they be convinced to
provide appropriate `install' target so we don't have to define `do-install'
one in the port?

./danfe