From owner-freebsd-hackers@FreeBSD.ORG  Thu Oct 21 18:23:14 2010
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1233)
	id 35C23106566B; Thu, 21 Oct 2010 18:23:14 +0000 (UTC)
Date: Thu, 21 Oct 2010 18:23:14 +0000
From: Alexander Best <arundel@freebsd.org>
To: Garrett Cooper <gcooper@FreeBSD.org>
Message-ID: <20101021182314.GA16569@freebsd.org>
References: <20101021174658.GA11107@freebsd.org>
	<AANLkTik0Kow_jsWrZOjv-jK7zkwSJosuuPOgb4ZF3Hkh@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AANLkTik0Kow_jsWrZOjv-jK7zkwSJosuuPOgb4ZF3Hkh@mail.gmail.com>
Cc: freebsd-hackers@freebsd.org
Subject: Re: a few minor kldstat fixes
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Oct 2010 18:23:14 -0000

On Thu Oct 21 10, Garrett Cooper wrote:
> On Thu, Oct 21, 2010 at 10:46 AM, Alexander Best <arundel@freebsd.org> wrote:
> > this patch fixes the following issues:
> >
> > - unbreak 'kldstat -i 999 -v' output
> > - remove an unnecessary set of "{" and "}"
> > - change printfile() to blend into the overall style used in kldstat.c
> > - add a kldstat(8) entry to document the relationship between the "-i" and "-n" flags
> 
>     Might be better to say that the -i and -n options are mutually
> exclusive in the manpage, and have the args parser parse out those two
> cases and bail if both of them are set.

i don't think the current behavior should be changed. some people might have
something like 'kldstat -i X -n Y' in their scripts expect "-n Y" to override
"-i X", instead of having kldstat fail.

> Thanks!
> -Garrett

-- 
a13x