From owner-cvs-src-old@FreeBSD.ORG Wed Jun 23 23:08:22 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9907F1065674 for ; Wed, 23 Jun 2010 23:08:22 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6D3D18FC17 for ; Wed, 23 Jun 2010 23:08:22 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o5NN8M8U092181 for ; Wed, 23 Jun 2010 23:08:22 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o5NN8Mgf092180 for cvs-src-old@freebsd.org; Wed, 23 Jun 2010 23:08:22 GMT (envelope-from pjd@repoman.freebsd.org) Message-Id: <201006232308.o5NN8Mgf092180@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to pjd@repoman.freebsd.org using -f From: Pawel Jakub Dawidek Date: Wed, 23 Jun 2010 23:07:57 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: RELENG_8_1 Subject: cvs commit: src/sbin/hastd ebuf.c hast_proto.c hastd.c metadata.c nv.c primary.c secondary.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jun 2010 23:08:22 -0000 pjd 2010-06-23 23:07:57 UTC FreeBSD src repository Modified files: (Branch: RELENG_8_1) sbin/hastd ebuf.c hast_proto.c hastd.c metadata.c nv.c primary.c secondary.c Log: SVN rev 209488 on 2010-06-23 23:07:57Z by pjd MFC r209263: r209175: Eliminate dead code. Found by: Coverity Prevent CID: 5158 r209177: Remove macros that are not really needed. The idea was to have them in case we grow more descriptors, but I'll reconsider readding them once we get there. Passing (a = b) expression to FD_ISSET() is bad idea, as FD_ISSET() evaluates its argument twice. Found by: Coverity Prevent CID: 5243 r209179: Plug memory leaks. Found by: Coverity Prevent CID: 7052, 7053, 7054, 7055 r209180: Plug memory leak. Found by: Coverity Prevent CID: 7051 r209181: Plug memory leak. Found by: Coverity Prevent CID: 7056 r209182: Plug memory leak. Found by: Coverity Prevent CID: 7057 r209183: Initialize gctl_seq for synchronization requests. Reported by: hiroshi@soupacific.com Analysed by: Mikolaj Golub Tested by: hiroshi@soupacific.com, Mikolaj Golub r209184: Fix typos. r209185: Correct various log messages. Submitted by: Mikolaj Golub Note that without some of these changes hastd won't work on 8.x properly. Approved by: re (kensmith) Revision Changes Path 1.1.2.2.2.2 +7 -7 src/sbin/hastd/ebuf.c 1.1.2.3.2.2 +1 -3 src/sbin/hastd/hast_proto.c 1.2.2.4.2.2 +14 -22 src/sbin/hastd/hastd.c 1.1.2.3.2.2 +10 -6 src/sbin/hastd/metadata.c 1.1.2.2.2.2 +2 -0 src/sbin/hastd/nv.c 1.3.2.4.2.2 +5 -1 src/sbin/hastd/primary.c 1.1.2.3.2.2 +2 -1 src/sbin/hastd/secondary.c