From owner-freebsd-bugs@FreeBSD.ORG  Wed Feb 25 14:22:41 2015
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 04C80D19
 for <freebsd-bugs@FreeBSD.org>; Wed, 25 Feb 2015 14:22:41 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id DF569E27
 for <freebsd-bugs@FreeBSD.org>; Wed, 25 Feb 2015 14:22:40 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t1PEMe9j024214
 for <freebsd-bugs@FreeBSD.org>; Wed, 25 Feb 2015 14:22:40 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 198014] Signals can lead to an inconsistency in PI mutex
 ownership
Date: Wed, 25 Feb 2015 14:22:40 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 11.0-CURRENT
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: eric@vangyzen.net
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-198014-8-4AI1Asf9pc@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-198014-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-198014-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Feb 2015 14:22:41 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198014

--- Comment #10 from eric@vangyzen.net ---
I considered this, but I'm indecisive.  The current "userland messed the mutex"
error path compounds the problem by leaving the umutex owned by the current
thread, while libthr already disowned the pthread_mutex.  I wonder if it should
disown the umutex.  This might allow the mutex owner fields to regain
consistency.  On the other hand, maybe we should let it stay inconsistent to
make the failure more permanent; this might prevent the application from
corrupting its state even further.

Regardless, you're right that the empty case should be consistent with the
non-empty case when another thread owns the umtx_pi, since I believe this is
still an error.  Note that the umtx_pi could legitimately be unowned in the
empty case, such as immediately after umtx_pi_alloc.

I'm testing an updated patch now.

-- 
You are receiving this mail because:
You are the assignee for the bug.