Date: Fri, 22 Apr 2016 15:02:14 -0700 From: Ngie Cooper <yaneurabeya@gmail.com> To: Bryan Drewery <bdrewery@freebsd.org> Cc: Garrett Cooper <ngie@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r297836 - head/lib/msun/tests Message-ID: <CAGHfRMA6Jqa4RGFOgewvag=mMaopGjcBu02yNL52CJTXX1BO5A@mail.gmail.com> In-Reply-To: <570C6BD4.5030609@FreeBSD.org> References: <201604112115.u3BLFmN9003703@repo.freebsd.org> <570C6BD4.5030609@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 11, 2016 at 8:30 PM, Bryan Drewery <bdrewery@freebsd.org> wrote= : > On 4/11/2016 2:15 PM, Garrett Cooper wrote: >> Author: ngie >> Date: Mon Apr 11 21:15:48 2016 >> New Revision: 297836 >> URL: https://svnweb.freebsd.org/changeset/base/297836 >> >> Log: >> Fix appending -O0 to CFLAGS > > This seems to be a NOP. > >> >> The previous method would completely nerf CFLAGS once bsd.progs.mk had > > I'm not seeing 'completely nerf' in a diff: >> -/usr/local/bin/ccache cc -O2 -pipe -DHAVE_FENV_H -D__HAVE_LONG_DOUBLE -= DLDBL_PREC=3D64 -O0 -g -std=3Diso9899:1999 -fstack-protector-strong -Wno-= unknown-pragmas -fcolor-diagnostics -Qunused-arguments -c /root/git/free= bsd/lib/msun/tests/nearbyint_test.c -o nearbyint_test.o >> -cc -O2 -pipe -DHAVE_FENV_H -D__HAVE_LONG_DOUBLE -DLDBL_PREC=3D64 -O0 -g= -std=3Diso9899:1999 -fstack-protector-strong -Wno-unknown-pragmas -fcolor-= diagnostics -Qunused-arguments -o nearbyint_test.full nearbyint_test.o -= lm >> +/usr/local/bin/ccache cc -O2 -pipe -DHAVE_FENV_H -D__HAVE_LONG_DOUBLE -= O0 -DLDBL_PREC=3D64 -g -std=3Diso9899:1999 -fstack-protector-strong -Wno-= unknown-pragmas -fcolor-diagnostics -Qunused-arguments -c /root/git/free= bsd/lib/msun/tests/nearbyint_test.c -o nearbyint_test.o >> +cc -O2 -pipe -DHAVE_FENV_H -D__HAVE_LONG_DOUBLE -O0 -DLDBL_PREC=3D64 -g= -std=3Diso9899:1999 -fstack-protector-strong -Wno-unknown-pragmas -fcolor-= diagnostics -Qunused-arguments -o nearbyint_test.full nearbyint_test.o -= lm > > It's simply moving it earlier, since it comes before the CFLAGS+=3D-DLDBL= _PREC > > I diff'd the entire output and all were the same as this. > > Am I missing something? What prompted me to do this (and brought me to this incorrect conclusion) originally is that I was trying to figure out why make -VCFLAGS.fminmax_test wasn't outputting -O* the way I thought it would. After doing some digging, yes... it was a silly nop :(... in retrospect (jhb was right) I shouldn't have MFCed it :/. I'll "revert" the change in the next go-around with this Makefile.. Thanks, -Ngie
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMA6Jqa4RGFOgewvag=mMaopGjcBu02yNL52CJTXX1BO5A>