From owner-p4-projects@FreeBSD.ORG Sun Dec 3 17:47:17 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id A437316A47B; Sun, 3 Dec 2006 17:47:17 +0000 (UTC) X-Original-To: perforce@FreeBSD.org Delivered-To: perforce@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 48A5416A416 for ; Sun, 3 Dec 2006 17:47:17 +0000 (UTC) (envelope-from rdivacky@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id 10DC543CA5 for ; Sun, 3 Dec 2006 17:46:49 +0000 (GMT) (envelope-from rdivacky@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kB3HlGRq050156 for ; Sun, 3 Dec 2006 17:47:16 GMT (envelope-from rdivacky@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kB3HlGpR050153 for perforce@freebsd.org; Sun, 3 Dec 2006 17:47:16 GMT (envelope-from rdivacky@FreeBSD.org) Date: Sun, 3 Dec 2006 17:47:16 GMT Message-Id: <200612031747.kB3HlGpR050153@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to rdivacky@FreeBSD.org using -f From: Roman Divacky To: Perforce Change Reviews Cc: Subject: PERFORCE change 110957 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Dec 2006 17:47:17 -0000 http://perforce.freebsd.org/chv.cgi?CH=110957 Change 110957 by rdivacky@rdivacky_witten on 2006/12/03 17:46:16 Use TAILQ_FOREACH_SAFE instead of unsafe variant in linsysfs_uninit because we are deleting the element we are using. Affected files ... .. //depot/projects/linuxolator/src/sys/compat/linsysfs/linsysfs.c#2 edit Differences ... ==== //depot/projects/linuxolator/src/sys/compat/linsysfs/linsysfs.c#2 (text) ==== @@ -268,9 +268,10 @@ static int linsysfs_uninit(PFS_INIT_ARGS) { - struct scsi_host_queue *scsi_host; + struct scsi_host_queue *scsi_host, *scsi_host_temp; - TAILQ_FOREACH(scsi_host, &scsi_host_q, scsi_host_next) { + TAILQ_FOREACH_SAFE(scsi_host, &scsi_host_q, scsi_host_next, + scsi_host_temp) { TAILQ_REMOVE(&scsi_host_q, scsi_host, scsi_host_next); free(scsi_host->path, M_TEMP); free(scsi_host, M_TEMP);