Date: Mon, 17 Jul 2023 10:52:24 -0700 From: John Baldwin <jhb@FreeBSD.org> To: Warner Losh <imp@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: d3152ab23e0e - main - tcbpcb: Always define t_osd Message-ID: <ba89809b-0af3-8eb6-afd2-68606450f186@FreeBSD.org> In-Reply-To: <202307171735.36HHZonv063454@gitrepo.freebsd.org> References: <202307171735.36HHZonv063454@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7/17/23 10:35 AM, Warner Losh wrote: > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=d3152ab23e0e7bee5a0f988ecca2a1187ab82057 > > commit d3152ab23e0e7bee5a0f988ecca2a1187ab82057 > Author: Warner Losh <imp@FreeBSD.org> > AuthorDate: 2023-07-17 17:22:45 +0000 > Commit: Warner Losh <imp@FreeBSD.org> > CommitDate: 2023-07-17 17:22:45 +0000 > > tcbpcb: Always define t_osd > > Always define t_osd. congestion control modules access it > unconditionally. This fixes the build. > > However, this is, at best, a temporary band-aide until the > larger issues are sorted. > > Sponsored by: Netflix FWIW, I find that #ifdef's based on kernel options in "core" structures like this shared with modules is a recipe for disaster. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ba89809b-0af3-8eb6-afd2-68606450f186>