From owner-freebsd-current@FreeBSD.ORG  Mon Oct 31 21:53:06 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9920016A41F;
	Mon, 31 Oct 2005 21:53:06 +0000 (GMT) (envelope-from jhb@freebsd.org)
Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 12BDC43D46;
	Mon, 31 Oct 2005 21:53:05 +0000 (GMT) (envelope-from jhb@freebsd.org)
Received: from [10.50.41.234] (Not Verified[10.50.41.234]) by
	mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8)
	id <B436696370000>; Mon, 31 Oct 2005 17:09:59 -0500
From: John Baldwin <jhb@freebsd.org>
To: freebsd-current@freebsd.org
Date: Mon, 31 Oct 2005 17:54:43 -0500
User-Agent: KMail/1.8.2
References: <200510311717.13419.jhb@freebsd.org>
In-Reply-To: <200510311717.13419.jhb@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200510311754.44010.jhb@freebsd.org>
Cc: current@freebsd.org
Subject: Re: [PATCH] push Giant down into fdfree()
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Oct 2005 21:53:06 -0000

On Monday 31 October 2005 05:17 pm, John Baldwin wrote:
> This patches pushes Giant down into fdfree() by using VFS_LOCK_GIANT for
> the occasional VOP_ADVLOCK() and moving various vrele() calls out from
> under the FILEDESC_LOCK.  Note that about half the calls to fdfree()
> (either directly or indirectly via fdunshare()) didn't lock Giant anyway. 
> Please review and/or test, thanks!
>
> http://www.FreeBSD.org/~jhb/patches/fdfree.patch

Nm on this one. :)  Looks like csjp@ already has this mostly done (I thought I 
had seen this talked about on IRC).

-- 
John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org