From owner-freebsd-ports@FreeBSD.ORG Wed Jun 1 14:30:52 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A1E11106566B for ; Wed, 1 Jun 2011 14:30:52 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 319EF8FC18 for ; Wed, 1 Jun 2011 14:30:51 +0000 (UTC) Received: by fxm11 with SMTP id 11so124338fxm.13 for ; Wed, 01 Jun 2011 07:30:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:from :date:x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=8/hLKlP7Nq2jVmp9IRbz8YsSl/hBflazW5sAQuRhZpc=; b=qcAJvxofJW4X7AQMMUwClE3mVoPRqGRzO3o5VKxcKhMw0JVl8veaxiES6Cbc0qMRKf C+IpdOgrKzzCVG6dIBPmRti+qudto4xhnvQnsOjt3aElQd4O2anRRFWwBMsDLaW/zTdC Gc4IuBKDKWWqi2DV0HcOxqVn1ra0qB1BVgBKc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=fXn1TCg5CaEGgUiEejxTstmIwAucdXuvgbYyJz6HXg6Fun6Fj02MXN8y+Q7suEQIPQ TdwWVvd3VIMEywfBdfXr3K5E2yBbeZwQytizVhLlKsLDCigwu+t4ohSNrWxG9IlWCnfm MyfA5HTb30s+c6u7KhoLU5JH3oLFkK2WT/vIQ= Received: by 10.223.98.5 with SMTP id o5mr1757458fan.33.1306938650849; Wed, 01 Jun 2011 07:30:50 -0700 (PDT) MIME-Version: 1.0 Sender: baptiste.daroussin@gmail.com Received: by 10.223.100.150 with HTTP; Wed, 1 Jun 2011 07:30:25 -0700 (PDT) In-Reply-To: <4DE64BC7.5040804@gmx.de> References: <4DE5D8C9.3020506@icyb.net.ua> <4DE6244E.1040301@FreeBSD.org> <20110601114442.GB2223@reindeer.exwg.net> <4DE6392D.5000106@gmx.de> <20110601131956.GC2223@reindeer.exwg.net> <4DE64546.7070604@FreeBSD.org> <4DE64BC7.5040804@gmx.de> From: Baptiste Daroussin Date: Wed, 1 Jun 2011 16:30:25 +0200 X-Google-Sender-Auth: 1kFI34wq1ONMSV8BvNnx9ig_VpI Message-ID: To: Matthias Andree Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: amatus@gnu.org, freebsd-ports@freebsd.org Subject: Re: lang/guile build fails for me X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jun 2011 14:30:52 -0000 2011/6/1 Matthias Andree : > Am 01.06.2011 15:57, schrieb Andriy Gapon: >> on 01/06/2011 16:19 Christoph Moench-Tegeder said the following: >>> Ah, yes, LDFLAGS. The port's Makefile already has >>> LDFLAGS=3D"-L${LOCALBASE}/lib" in $CONFIGURE_ENV, and as guile's config= ure >> >> BTW, I think that CONFIGURE_ENV in the port's Makefile better be set wit= h +=3D, for >> safety. > > Sure, but that doesn't help if you add new varname=3Dvalue assignments fo= r > the same varname - these aren't cumulative as you've shown. > >>> is a standard autoconf configure, $LDFLAGS should be picked up (the >>> output of "./configure --help" supports this), but... well, it isn't. >> >> Looks like LDFLAGS are lost from the environment before configure is run= : >> ac_cv_env_LDFLAGS_set=3Dset >> ac_cv_env_LDFLAGS_value=3D' -rpath=3D/usr/lib:/usr/local/lib' >> >> And given the USE_NCURSES workaround posted in this thread, that takes t= o >> Mk/bsd.ncurses.mk where we have: >> ... >> NCURSES_LDFLAGS+=3D =A0 =A0 =A0 -rpath=3D${NCURSESRPATH} >> >> .if defined(LDFLAGS) >> LDFLAGS+=3D${NCURSES_LDFLAGS} >> .else >> LDFLAGS=3D${NCURSES_LDFLAGS} >> .endif >> >> CONFIGURE_ENV+=3D =A0 =A0 =A0 =A0 LDFLAGS=3D"${LDFLAGS}" >> ... >> >> I think that the above line overrides whatever is set in the port's Make= file. > > Plausible - because there would be two different LDFLAGS=3D"mumble" > options in CONFIGURE_ENV, can you check that? > > make -V CONFIGURE_ENV =A0 or =A0 make -n do-configure =A0 =A0should revea= l that. > > Note that LDFLAGS isn't used by bsd.port.mk itself, in contrast to > CPPFLAGS, so that ports can't be expected to set this variable either. > > That makes bsd.ncurses.mk incompatible with a few more ports than just > guile I suppose... Cc'ing bapt@. =A0 =A0It appears diligent to look at al= l > ports that set USE_NCURSES. > > (Still the other observed port inconsistencies should get fixed, too.) > > -- > Matthias Andree > If someone comes with a better solution for USE_NCURSES please be aware that the solution will also fits with USE_OPENSSL so that the job won't be done twice. Anyway I think the fix is not to add anyflags to configure_env manually (would it be from USE_* of in the ports itself) Maybe LDFLAGS should always be appended to CONFIGURE_ENV has it has been done for CPPFLAGS. regards, Bapt