Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 17 Jun 2012 11:16:17 +0000 (UTC)
From:      Marius Strobl <marius@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org
Subject:   svn commit: r237192 - stable/8/sys/dev/ata/chipsets
Message-ID:  <201206171116.q5HBGHTH004749@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: marius
Date: Sun Jun 17 11:16:17 2012
New Revision: 237192
URL: http://svn.freebsd.org/changeset/base/237192

Log:
  MFC: r237107
  
  - As a baind-aid, disable ATAPI DMA when using ATA_CAM for these controllers
    as well as it causes the kernel to hang during boot.
    Reported and tested by: Kevin Oberman
  - Use NULL instead of 0 for a pointer.

Modified:
  stable/8/sys/dev/ata/chipsets/ata-ite.c
Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/amd64/include/xen/   (props changed)
  stable/8/sys/boot/   (props changed)
  stable/8/sys/cddl/contrib/opensolaris/   (props changed)
  stable/8/sys/contrib/dev/acpica/   (props changed)
  stable/8/sys/contrib/pf/   (props changed)
  stable/8/sys/dev/e1000/   (props changed)

Modified: stable/8/sys/dev/ata/chipsets/ata-ite.c
==============================================================================
--- stable/8/sys/dev/ata/chipsets/ata-ite.c	Sun Jun 17 11:16:14 2012	(r237191)
+++ stable/8/sys/dev/ata/chipsets/ata-ite.c	Sun Jun 17 11:16:17 2012	(r237192)
@@ -105,10 +105,10 @@ ata_ite_chipinit(device_t dev)
 
 	ctlr->setmode = ata_ite_821x_setmode;
 	/* No timing restrictions initally. */
-	ctlr->chipset_data = (void *)0;
+	ctlr->chipset_data = NULL;
     }
     ctlr->ch_attach = ata_ite_ch_attach;
-    return 0;
+    return (0);
 }
 
 static int
@@ -119,6 +119,9 @@ ata_ite_ch_attach(device_t dev)
  
 	error = ata_pci_ch_attach(dev);
 	ch->flags |= ATA_CHECKS_CABLE;
+#ifdef ATA_CAM
+	ch->flags |= ATA_NO_ATAPI_DMA;
+#endif
 	return (error);
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201206171116.q5HBGHTH004749>