From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Feb 20 07:46:15 2004 Return-Path: Delivered-To: freebsd-ports-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2CB0F16A4CE for ; Fri, 20 Feb 2004 07:46:15 -0800 (PST) Received: from postman.arcor.de (newsread1.arcor-online.net [151.189.0.146]) by mx1.FreeBSD.org (Postfix) with ESMTP id 818D443D1F for ; Fri, 20 Feb 2004 07:46:14 -0800 (PST) (envelope-from eikemeier@fillmore-labs.com) Received: from fillmore.dyndns.org (port-212-202-184-227.reverse.qdsl-home.de [212.202.184.227]) (authenticated bits=0)i1KFkBtw029566 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Fri, 20 Feb 2004 16:46:12 +0100 (MET) Received: from [172.16.0.2] (helo=fillmore-labs.com) by fillmore.dyndns.org with esmtp (Exim 4.30; FreeBSD) id 1AuCqv-000GtZ-GN; Fri, 20 Feb 2004 16:46:09 +0100 Message-ID: <40362BC1.5090508@fillmore-labs.com> Date: Fri, 20 Feb 2004 16:46:09 +0100 From: Oliver Eikemeier Organization: Fillmore Labs GmbH - http://www.fillmore-labs.com/ MIME-Version: 1.0 To: "Sergey A. Osokin" References: <20040220135839.GH49750@freebsd.org.ru> In-Reply-To: <20040220135839.GH49750@freebsd.org.ru> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit User-Agent: KMail/1.5.9 cc: freebsd-ports-bugs@FreeBSD.org cc: Vivek Khera Subject: Re: Subject: Re: ports/62690: Postfix with LDAP support fails to compile X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2004 15:46:15 -0000 Sergey A. Osokin wrote: > On Fri, Feb 20, 2004 at 02:22:29PM +0100, Oliver Eikemeier wrote: > >>Sergey A. Osokin wrote: >> >>>[...] >>> >>>I would like to commit following patch, its also fix build problem >>>with openldap20, please review and approve. >> >>FYI: OpenLDAP 2.0 is deprecated and scheduled for removal May 2004. >>OpenLDAP 1.2 will be removed April 2004 and shouldn't be used under any >>circumstances (it is marked FORBIDDEN). >> >>Generally users expect that when they set WANT_OPENLDAP_VER in make.conf(5), >>pkgtools.conf(5) or on the command line that this is honored by ports. >>The rationale is that different versions of OpenLDAP can't coexist and >>it is therefore easy for the user to choose her preferred version. >> >>Furthermore WANT_OPENLDAP_VER has a default in bsd.port.mk, which makes it >>easy to switch versions and build non-conflicting packages. Currently >>OpenLDAP 2.1 is the default, but I plan to switch to 2.2 if it is stable >>enough and eventually the OpenLDAP project ceases support for 2.1. >> >>I am aware that this doesn't fit well in the scheme how postfix >>configuration works now, but it would be nice if we could have a >>consistent ports tree, at last in this regard. > > OK, I see your point of view. Do you have any patches against current > version of postfix port? Sorry, no. Thats why I called it a suggestion. I can make some suggestions, but I don't want to rewrite and test postfix configuration. So, in case you don't want to do this, consider my list as `nice to have' and leave everything as it is. - you could just scrap the `dialog' part, since we now have permanent OPTIONS - considering OpenLDAP, I would choose something like OpenLDAP "OpenLDAP map lookups" "$status_OpenLDAP" and use echo "BUILD_DEPENDS+= \${LOCALBASE}/lib/libldap.a:\${PORTSDIR}/net/openldap${WANT_OPENLDAP_VER}-client" echo "OPENLDAP_SUFFIX= +openldap${WANT_OPENLDAP_VER}" WANT_OPENLDAP_VER is available *after* bsd.port.pre.mk, but late evaluation may help you. Otherwise its getting difficult, but you might want to use the dynamic libraries anyway (and enjoy the benefits of USE_OPENLDAP). This requires users that want to use a different version than the default one to use WANT_OPENLDAP_VER=22 on the command line. This does not really fit into the schema how postfix is configured now, but most people should be happy with it, since using a newer OpenLDAP version normally doesn't have much benefits for a client. But maybe Vivek can come up with something *much* better ;) Anyway, go ahead and commit the original patch, I just wanted to give you a heads-up that things will change in April/May. Thanks for your quick feedback Oliver