From owner-freebsd-bugs  Sun Jun 16 18:20:05 1996
Return-Path: owner-bugs
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id SAA03367
          for bugs-outgoing; Sun, 16 Jun 1996 18:20:05 -0700 (PDT)
Received: (from gnats@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id SAA03345;
          Sun, 16 Jun 1996 18:20:02 -0700 (PDT)
Resent-Date: Sun, 16 Jun 1996 18:20:02 -0700 (PDT)
Resent-Message-Id: <199606170120.SAA03345@freefall.freebsd.org>
Resent-From: gnats (GNATS Management)
Resent-To: freebsd-bugs
Resent-Reply-To: FreeBSD-gnats@freefall.FreeBSD.org, hsu@clinet.fi
Received: from hauki.clinet.fi (root@hauki.clinet.fi [194.100.0.1])
          by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id SAA03096
          for <FreeBSD-gnats-submit@freebsd.org>; Sun, 16 Jun 1996 18:13:25 -0700 (PDT)
Received: from katiska.clinet.fi (root@katiska.clinet.fi [194.100.0.4]) by hauki.clinet.fi (8.7.5/8.6.4) with ESMTP id EAA29512 for <FreeBSD-gnats-submit@freebsd.org>; Mon, 17 Jun 1996 04:13:19 +0300 (EET DST)
Received: (hsu@localhost) by katiska.clinet.fi (8.7.5/8.6.4) id EAA20317; Mon, 17 Jun 1996 04:13:17 +0300 (EET DST)
Message-Id: <199606170113.EAA20317@katiska.clinet.fi>
Date: Mon, 17 Jun 1996 04:13:17 +0300 (EET DST)
From: Heikki Suonsivu <hsu@clinet.fi>
Reply-To: hsu@clinet.fi
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: bin/1328: install silently removes target if strip is unexecutable
Sender: owner-bugs@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk


>Number:         1328
>Category:       bin
>Synopsis:       install silently removes target if strip is unexecutable
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jun 16 18:20:01 PDT 1996
>Last-Modified:
>Originator:     Heikki Suonsivu
>Organization:
Clinet, Espoo, Finland
>Release:        FreeBSD 2.2-CURRENT i386
>Environment:

	-current (probably applies to other versions?)

>Description:

	I had a panic when the system was compiling strip, and
unfortunately I did not notice that strip binary had become a 0-size
file with 644 modes.  After I retried make world, it said

install ... -s ...
strip: permission denied

for all programs and removed the targets!

Fortunately make stopped after removing things like echo and cp, when
it tried to ln -s something to something else, so with 10 minutes of
figuring out what was going on and manual installing I got the
binaries back where they belong.

>How-To-Repeat:

make strip 0-sized file with 644 permissions and do a make world
(probably just doing install is enough).

>Fix:

Files should not get removed if strip fails.

If install fails, it should return non-zero exit value so that make
will stop before serious damage gets done.

>Audit-Trail:
>Unformatted: