From owner-svn-ports-all@freebsd.org  Thu Dec  6 15:26:47 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 63B781331B64;
 Thu,  6 Dec 2018 15:26:47 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id F377B70F21;
 Thu,  6 Dec 2018 15:26:46 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id E2DE7C534; Thu,  6 Dec 2018 15:26:46 +0000 (UTC)
Date: Thu, 6 Dec 2018 15:26:46 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Christoph Moench-Tegeder <cmt@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r486763 - head/graphics/gexiv2/files
Message-ID: <20181206152646.GA93198@FreeBSD.org>
References: <201812061452.wB6EqFCB073812@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201812061452.wB6EqFCB073812@repo.freebsd.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Rspamd-Queue-Id: F377B70F21
X-Spamd-Result: default: False [-1.21 / 15.00];
 local_wl_from(0.00)[freebsd.org];
 NEURAL_HAM_MEDIUM(-0.68)[-0.680,0];
 NEURAL_HAM_SHORT(-0.96)[-0.957,0];
 NEURAL_SPAM_LONG(0.42)[0.424,0];
 ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]
X-Rspamd-Server: mx1.freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Dec 2018 15:26:47 -0000

On Thu, Dec 06, 2018 at 02:52:15PM +0000, Christoph Moench-Tegeder wrote:
> New Revision: 486763
> URL: https://svnweb.freebsd.org/changeset/ports/486763
> 
> Log:
>   gexiv2: fix build with non-clang compilers
>   
> [...]
> --- head/graphics/gexiv2/files/patch-gexiv2_meson.build	Thu Dec  6 14:26:22 2018	(r486762)
> +++ head/graphics/gexiv2/files/patch-gexiv2_meson.build	Thu Dec  6 14:52:15 2018	(r486763)
> @@ -1,11 +1,16 @@
> ---- gexiv2/meson.build.orig	2018-11-23 19:55:20 UTC
> -+++ gexiv2/meson.build
> -@@ -35,7 +35,7 @@ install_headers(gexiv2_headers, subdir :
> +--- gexiv2/meson.build.orig	2018-12-01 18:58:21.005598000 +0100
> ++++ gexiv2/meson.build	2018-12-01 19:01:56.566055000 +0100
> +@@ -35,10 +35,10 @@

May I wonder why did you squash correct +++/--- lines format?  Please use
``make makepatch'' when (re)generating patches next time.

Additionally, you might want to get into habbit of doing "svn diff" before
commit, it would have shown that.

./danfe