From owner-freebsd-current@FreeBSD.ORG  Tue Sep 27 09:21:06 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@FreeBSD.org
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8114316A41F;
	Tue, 27 Sep 2005 09:21:06 +0000 (GMT)
	(envelope-from truckman@FreeBSD.org)
Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3928B43D49;
	Tue, 27 Sep 2005 09:21:06 +0000 (GMT)
	(envelope-from truckman@FreeBSD.org)
Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2])
	by gw.catspoiler.org (8.13.3/8.13.3) with ESMTP id j8R9Kvjh098113;
	Tue, 27 Sep 2005 02:21:01 -0700 (PDT)
	(envelope-from truckman@FreeBSD.org)
Message-Id: <200509270921.j8R9Kvjh098113@gw.catspoiler.org>
Date: Tue, 27 Sep 2005 02:20:57 -0700 (PDT)
From: Don Lewis <truckman@FreeBSD.org>
To: kris@obsecurity.org
In-Reply-To: <20050926180615.GA61075@xor.obsecurity.org>
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=us-ascii
Cc: freebsd-current@FreeBSD.org, obrien@FreeBSD.org
Subject: Re: [PANIC] ufs_dirbad: bad dir
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Sep 2005 09:21:06 -0000

On 26 Sep, Kris Kennaway wrote:
> On Mon, Sep 26, 2005 at 09:08:08AM -0700, David O'Brien wrote:
>> On Mon, Sep 26, 2005 at 08:29:52AM -0700, David O'Brien wrote:
>> > Anyone own this one?
>> > The running kernel was:
>> >     FreeBSD 7.0-CURRENT #528: Sun Sep 25 21:07:22 PDT 2005
>> ... 
>> > panic messages:
>> > panic: ufs_dirbad: bad dir
>> 
>> Just got another one - uptime was about 10 minutes.  Is one of the recent
>> changes to SU & FFS making this situation easier to trigger?
> 
> As I've mentioned the last few times you reported this, it's a
> long-standing bug that has existed since the FreeBSD 4.x days or
> before.  Try to fsck -f your filesystems to make sure there is no
> lingering damage.

I think there is a soft updates bug that can leave directories in an
inconsistent state after a crash.  If you are experiencing this problem,
I would recommend making sure that all of your file systems are clean by
running fsck -f, and then disabling background_fsck.  Be on the lookout
for any unexpected soft updates inconsistencies after system crashes
(other than those caused by power failures if disk write caching is
enabled). If the ufs_dirbad panics still happen when starting from known
clean file systems, then the problem is something that I'm unaware of.
The message printed before the panic string would also be helpful.

ufs_dirbad() should probably be re-written to combine the printf()
string with the panic() string.