From owner-svn-src-all@freebsd.org Mon Nov 20 19:05:57 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 006F7DF2FE1 for ; Mon, 20 Nov 2017 19:05:57 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x235.google.com (mail-it0-x235.google.com [IPv6:2607:f8b0:4001:c0b::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B61556858A for ; Mon, 20 Nov 2017 19:05:56 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x235.google.com with SMTP id b5so13218003itc.3 for ; Mon, 20 Nov 2017 11:05:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Mc2oeDUaObUVVjBiG0/hTSjex6O5hYNtWMeGt/gaFc8=; b=kDXNRr9QkiJIDY7QvObZqtYZeWf8M2BGE+D3ZTy4g9lcrYj+HfwgmQYdMfse64hy5r fqP/IWMGs++s9v0KsS5unWgSF4/nJhGoRYgI0EHaBwniFw2gbqvHw38jPzD+NUbYznIX jWQWoiV14zrN+OnBPPjl1/iwWj2VNhclwqPLRqpo0F3oyjeGt2eedMH1mHi40kxDTdTF l5zI0KaZcOBsBZUUmcDe7FiCCCGKuYxVlqm0tX6jvgO/UOHdqXFZ1bs23T4JKOHPKMY1 XSBzAcMJcerDogy/+eUbmI+rZRC8aGQXd+QHYqmrtVamuIotcU0nHd4TpuCBKBpsJ1Hh 7Cxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Mc2oeDUaObUVVjBiG0/hTSjex6O5hYNtWMeGt/gaFc8=; b=XMM8RGRHQ4osjfmYIKWtuZkqzhgMxgux0yjbmTmoD+uYQDps2KwSP3JdXDAU6kvfYH 2jEf+Cw0rcpdRtB1NjZ7Lh1lNeFaRVoEz/fDtnElzGkFnFi/EXk/jOMdclPS2bKHnlme IdEO+zRnCHDOd/9vp88+J4uWFXpEJ03jfqrDXIyYQDd7FvxBvbGYbI3n0y2RNRik5Fz4 mq661YvU+Oj7IZcuJK4LmPOS0P9JNU6Pu3ngbiqcXqD1nzVwTnYa9ndwSDfexhILYZE9 g1cF6Zi1hkOMc6YrdcEZxTVOS4REIVgKON3HEwg4fHRz9X++4/rLDRWEyzFKc2AdgZ1i NAbA== X-Gm-Message-State: AJaThX7YS7d818+3OIvSDQnHcXoyAQiwqJ+tcFXj/tJZwiWd/EdtjmCd uu+t+PA/b4h6gOj6ho2kHtTnKbEl4oiMWl4Jx6oS8A== X-Google-Smtp-Source: AGs4zMbrigKhNRTkwJfYDDOvT7tSy8RJXCfrEFDMjtkTGr2xmi3p1gXJya15lWRwMfRhsO5vCrmwYApTW3H9qGs8Xeo= X-Received: by 10.36.94.129 with SMTP id h123mr14933363itb.64.1511204755782; Mon, 20 Nov 2017 11:05:55 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.108.204 with HTTP; Mon, 20 Nov 2017 11:05:54 -0800 (PST) X-Originating-IP: [67.135.20.194] Received: by 10.79.108.204 with HTTP; Mon, 20 Nov 2017 11:05:54 -0800 (PST) In-Reply-To: References: <201711190031.vAJ0VE9m016670@repo.freebsd.org> <20171119173822.J974@besplex.bde.org> From: Warner Losh Date: Mon, 20 Nov 2017 12:05:54 -0700 X-Google-Sender-Auth: kJDC1RM9Hh95M8b_J6BBgpLNCaw Message-ID: Subject: Re: svn commit: r325988 - head/sys/libkern To: Ed Maste Cc: Bruce Evans , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Nov 2017 19:05:57 -0000 On Nov 20, 2017 9:57 AM, "Ed Maste" wrote: Hi Bruce, notes on a few of the points you raised (I'll look at others later): On 19 November 2017 at 04:07, Bruce Evans wrote: > > The vendor version is in libc/string. It has been ANSIfied, but the > libkern version has large churning to "optimize" it. It is the libkern > version that should have been optimized, since bcmp is unimportant in > the kernel and in most applications, but applications have a wider range > so a few might benefit from optimizing it. I presume you meant "it is the _libc_ version that should have been optimized", but could also read this as a distinction between optimized and scare-quotes "optimized." > bcmp is actually optimized > in the kernel in support.[sS] for all arches except powerpc and riscv, > so optimizing the kernel MI version of it is especially unimportant. > In libc where MD optimizations are more important, they are also not > done for arm, arm64 and sparc64. This could make a nice small project for someone to take on. > - libc version copyright comment not marked for indent protection using > "/*-" (this has been subverted to have another meaning which I forget). I don't believe there's another meaning. IIRC imp@ has pointed out that it means precisely what you've mentioned above. All our copyright notices are marked for protection from indent. I made that change. It was so that we could filter out all the extra junk quickly in the conformance scripts people were writing. And these things should be protected from indent too. Warner >> Modified: head/sys/libkern/cmpdi2.c >> Modified: head/sys/libkern/divdi3.c >> Modified: head/sys/libkern/lshrdi3.c > > Like ashrdi3.c (not ANSIfied in libc/quad). Ok, I will update libc/quad to match. > The above declaration was already correctly ANSIfied in libc/gmon. This > unimproves the style by keeping the comment misplaced at the right of the > code where it is a larger style bug than before -- not the line is too long. > ANSIfication in libc/gmon put it on a separate line. Will update the comment along with other mcount tidying. >> Modified: head/sys/libkern/strcmp.c > > The vendor version is in libc/string. It has been ANSIfied, but the commit > that did that also made another style fix. This change catches up with half > of the older change. Will update.