From nobody Sat Jan 29 23:15:42 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 9C512197AF29; Sat, 29 Jan 2022 23:15:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JmVYW00mqz3sNY; Sat, 29 Jan 2022 23:15:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1643498143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kDvDDmTwj5lG25cNu6ghwimaRkWNabMn6G7W3Br7O/o=; b=hmYfD/dG9bjxoj9JkJsLCNHHOT5XyBh/aJ1SSv5fH35gNsJy9EsGmJZ0cXLafKOUS6GSzy j4JZ9mTHfUKL3n5ax0Q09wj4huJgajGjRGSdDVqIF573xiJQYFNofV3svEoi71y0X1eMiD w3i2zro+OgUxFVtK+OFwe660BKdUrbzoGMdFjub9vMLfzX4zBzggpyuqVbNgNqiaGQUiRn PTPHc9Y30ks1NDy+T0nh//DVL+kCE0gHmPmYGGxDJg8/fwm3txJO3stYTauO4xTp9PO/yD 5Mkr4p5Ce+IRquxmWuS3qWeivHO4HtOV9jTOHNQP+OcwWnla/5B27e3m48FS5A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1EA291DF64; Sat, 29 Jan 2022 23:15:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 20TNFgpJ008231; Sat, 29 Jan 2022 23:15:42 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 20TNFgo7008230; Sat, 29 Jan 2022 23:15:42 GMT (envelope-from git) Date: Sat, 29 Jan 2022 23:15:42 GMT Message-Id: <202201292315.20TNFgo7008230@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Chuck Tuffli Subject: git: 45ab4076f36b - main - bhyve nvme: Remove redundant AER Limit checks List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: chuck X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 45ab4076f36b428595ba1ce200515fda6af58a76 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1643498143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kDvDDmTwj5lG25cNu6ghwimaRkWNabMn6G7W3Br7O/o=; b=oYmOFYJOX0Wn1xKDudMkP2jVQ9UOsHIFH/9gErGauGx1vshAZ63Uio2yzB5qp16tPcmUz2 Dkh6yadyjbHHl3w3N6sm7Ai9vyzSEdYEYZiZiKD7KwivBoVI7fuav1ssZj5WdWfybDFfyU sWV9N17xwGVhqRHJWLQux0kh0AZQLOlcMimY0EMAKDbXSfg+8EbeUDU0/S0dhAUhPlUyv6 Uae9NNCJ1ekjYvyUvn4zmJrgbwzF7Dhx0eVNg61BcsrT2dEBANbqRXHwlxibAFz+JfZ3k8 nNxgheo+dZjshYErGgvCoXPXgLsBkXnkYSqiUjUk78KOvspvCbUz9zjYitBCLA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1643498143; a=rsa-sha256; cv=none; b=LGfW3he1MMtbHhknC4vfjI+JN1bzxBfE9OoOYG5AACmhwc557Tvju19cHuFoC/jss8LsW9 ++e6sfjG9giBO+SfEnot7vUG8ArIrlA4Qdz8zG2Ef4M3F9npSUNAy9eT9P5WS8O889M/+D vSjHCq3mKpzdkwenfJfSk0GKItpGv1zcufSePzFWlBbFZJmmwwQQ0aRsY/JrXz/CNt10hY 68Fe8wluWgZdgmkBvmO4pteXAggLQ4uaGxQURU0gyvSdr8GwRzFfJfr2XMiwbUnq90pup2 h/NjChvm99S4Ejq8GvS/Iesqh6Cwi7Mz3OqWIkU7tRkuQaYNLFvjLKkarCmL4Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by chuck: URL: https://cgit.FreeBSD.org/src/commit/?id=45ab4076f36b428595ba1ce200515fda6af58a76 commit 45ab4076f36b428595ba1ce200515fda6af58a76 Author: Chuck Tuffli AuthorDate: 2022-01-30 07:07:29 +0000 Commit: Chuck Tuffli CommitDate: 2022-01-30 07:07:29 +0000 bhyve nvme: Remove redundant AER Limit checks The NVMe emulation checked if the Asynchronous Event Request Limit (a.k.a AERL) would be exceeded in pci_nvme_aer_add(), but this function is only called from nvme_opc_async_event_req() which also checks for exceeding the AERL. Reviewed by: imp, allanjude Tested by: jason@tubnor.net MFC after: 1 month Differential Revision: https://reviews.freebsd.org/D33570 --- usr.sbin/bhyve/pci_nvme.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/usr.sbin/bhyve/pci_nvme.c b/usr.sbin/bhyve/pci_nvme.c index c9aaf86ed7be..64a6e27aa90b 100644 --- a/usr.sbin/bhyve/pci_nvme.c +++ b/usr.sbin/bhyve/pci_nvme.c @@ -744,9 +744,6 @@ pci_nvme_aer_add(struct pci_nvme_softc *sc, uint16_t cid) { struct pci_nvme_aer *aer = NULL; - if (pci_nvme_aer_limit_reached(sc)) - return (-1); - aer = calloc(1, sizeof(struct pci_nvme_aer)); if (aer == NULL) return (-1);