Date: Thu, 14 May 2015 11:09:05 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Adam Weinberger <adamw@adamw.org> Cc: "Philip M. Gollucci" <pgollucci@p6m7g8.com>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org> Subject: Re: svn commit: r386285 - head/security/keychain Message-ID: <5554C8A1.50200@FreeBSD.org> In-Reply-To: <07ED759D-DFAC-44D0-A22B-1639EE3E0CB8@adamw.org> References: <201505140101.t4E11r9T031351@svn.freebsd.org> <08F806A7-3CD9-417A-BA4E-AF739E83B6A8@adamw.org> <CACM2dAaFL6F-=mbfODTRrR83L%2BGeLfxzcM16DoroP1shmP6NHQ@mail.gmail.com> <082DB80D-6385-4F4F-8A86-2DB4561E39E8@adamw.org> <5554C761.3060609@FreeBSD.org> <07ED759D-DFAC-44D0-A22B-1639EE3E0CB8@adamw.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --D2aSPSvI60Jco2eOa84ksB1MQuQ9qwPNo Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 5/14/2015 11:07 AM, Adam Weinberger wrote: >> On 14 May, 2015, at 10:03, Bryan Drewery <bdrewery@FreeBSD.org> wrote:= >> >> On 5/14/2015 11:00 AM, Adam Weinberger wrote: >>>> On 13 May, 2015, at 21:20, Philip M. Gollucci <pgollucci@p6m7g8.com>= wrote: >>>> >>>> Then it needs an option not an if exists() >>> >>> Bryan, can you please consider reverting it, or giving me approval to= revert it? It may fix the case when the port is built in poudriere witho= ut sshd in base, but it is a regression for everybody else. >>> >>> # Adam >>> >>> >> >> No. The way RUN_DEPENDS is supposed to work is what I said in the >> commit. These exists() checks are redundant and confuse the package >> dependencies. >> >> How are you building? It's possible the tool you are using is >> incorrectly handling RUN_DEPENDS. >=20 > Ah! I see. It's portmaster that's doing the misbehaving. The problem is= that openssh-portable still shows up in run-depends-list, and so portmas= ter decides that it is going to install openssh-portable first. >=20 > [root@apnoea /usr/ports/security/keychain] which ssh-agent > /usr/bin/ssh-agent > [root@apnoea /usr/ports/security/keychain] make run-depends-list > /usr/ports/security/openssh-portable > /usr/ports/shells/bash >=20 Ok. I'll look at portmaster and try to fix it now. We really need these exists() to go away; it causes rebuilds on the package cluster for no reason. This specific case is not one, but we need them to generally go away. --=20 Regards, Bryan Drewery --D2aSPSvI60Jco2eOa84ksB1MQuQ9qwPNo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVVMihAAoJEDXXcbtuRpfPu4oH/2aRqXNdJriYSsxBFrR5GCaY vbetE8wlZa5ntFCg+1jt7cWawLRwz6yihqXnBXLv9e/C2jOzR1pscOcbDMmxyZfu GUHE9oytZcJMMUC1jC9j1/+sr7Pa93BT5+EWR1N3371jIcbW91DPVs/gXxpJBjZL mjG7TZ7x6YMldDC9sZCK0pFo/vJlPp1mn4iZvrlkVO+v74tO8KK24KaviPOscn6+ LnGJJ4j3ipC4fCTzUZFdm+WFPB7ob6DrhZj7+ErBKGVD5iT06xpfD4Ans9jLiWDZ EHwxvbPWO5AubjleYxP+PTqPxGNrVpWGNq/IKl9Nh7ePShUbM32sFaDgqsQfp8o= =FiFN -----END PGP SIGNATURE----- --D2aSPSvI60Jco2eOa84ksB1MQuQ9qwPNo--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5554C8A1.50200>