From owner-p4-projects@FreeBSD.ORG Sun Dec 14 21:39:55 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id D6BD41065677; Sun, 14 Dec 2008 21:39:54 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9A80B1065672; Sun, 14 Dec 2008 21:39:54 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 5C62C8FC08; Sun, 14 Dec 2008 21:39:54 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id mBELbn41022006; Sun, 14 Dec 2008 14:37:49 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sun, 14 Dec 2008 14:37:49 -0700 (MST) Message-Id: <20081214.143749.58455689.imp@bsdimp.com> To: hselasky@c2i.net From: "M. Warner Losh" In-Reply-To: <200812141559.59329.hselasky@c2i.net> References: <200812131005.33499.hselasky@c2i.net> <20081213.130816.74659290.imp@bsdimp.com> <200812141559.59329.hselasky@c2i.net> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: sam@freebsd.org, perforce@freebsd.org Subject: Re: PERFORCE change 154573 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Dec 2008 21:39:55 -0000 In message: <200812141559.59329.hselasky@c2i.net> Hans Petter Selasky writes: : On Saturday 13 December 2008, Warner Losh wrote: : > From: Hans Petter Selasky : > Subject: Re: PERFORCE change 154573 for review : > Date: Sat, 13 Dec 2008 10:05:32 +0100 : > : : > : > This is absoultely the wrong way to implement this. It is so wrong, I : > don't even know where to begin. Consider this an 'over my dead body' : > level of objection to this design. : > : : We don't want to check a variable in the softc every time we do a htoleXX() ?? : : Do you have a better suggestion? Usually the bus_space stuff is used for situations like this so that the drivers don't have to care. Warner