From owner-freebsd-toolchain@FreeBSD.ORG  Wed Feb 11 19:18:46 2015
Return-Path: <owner-freebsd-toolchain@FreeBSD.ORG>
Delivered-To: freebsd-toolchain@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id D7EF4E2B
 for <freebsd-toolchain@freebsd.org>; Wed, 11 Feb 2015 19:18:46 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id B7FD5D36
 for <freebsd-toolchain@freebsd.org>; Wed, 11 Feb 2015 19:18:46 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t1BJIkGF038797
 for <freebsd-toolchain@freebsd.org>; Wed, 11 Feb 2015 19:18:46 GMT
 (envelope-from root@phabric-backend.isc.freebsd.org)
Received: (from root@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1BJIkvg038796;
 Wed, 11 Feb 2015 19:18:46 GMT (envelope-from root)
Date: Wed, 11 Feb 2015 19:18:46 +0000
To: freebsd-toolchain@freebsd.org
From: "kostikbel (Konstantin Belousov)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Accepted] D1826: libdwarf: Add symbol value when
 processing .rela relocations
Message-ID: <eb86db9c2ee3fdf45b1a77199fe48d8e@localhost.localdomain>
X-Priority: 3
Thread-Topic: D1826: libdwarf: Add symbol value when processing .rela
 relocations
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-axkijn4pfdxlezgbnt7g>
X-Phabricator-To: <PHID-USER-k5bbpaejfd56ik2tjj37>
X-Phabricator-To: <PHID-USER-2wocyy2vsyzu2nddvuw6>
X-Phabricator-Cc: <PHID-MLST-i5ptaleg3lqtvx7cknno>
In-Reply-To: <differential-rev-PHID-DREV-nmodhwpo2dxlqq7eii6c-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-nmodhwpo2dxlqq7eii6c-req@FreeBSD.org>
Thread-Index: ZjAwMzYxOWQ0Y2NkNDBkZjQ5NmIzZDI0ODQxIFTbqxY=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-other>, <differential-reviewers>,
 <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-toolchain@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Maintenance of FreeBSD's integrated toolchain
 <freebsd-toolchain.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-toolchain/>
List-Post: <mailto:freebsd-toolchain@freebsd.org>
List-Help: <mailto:freebsd-toolchain-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Feb 2015 19:18:46 -0000

kostikbel accepted this revision.
kostikbel added a comment.
This revision is now accepted and ready to land.

It looks fine, but definitely is extremely subtle.  The dwarf_get_reloc_size() returns zero for non-abs relocations, so dwarf_write_{m.l}sb() does nothing for other relocation types.

This at least deserves explanation in a comment.

REVISION DETAIL
  https://reviews.freebsd.org/D1826

To: emaste, rpaulo, kostikbel
Cc: freebsd-toolchain