From owner-cvs-ports@FreeBSD.ORG Sun Mar 14 04:57:04 2010 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E5947106564A for ; Sun, 14 Mar 2010 04:57:04 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 8F3FA8FC0C for ; Sun, 14 Mar 2010 04:57:04 +0000 (UTC) Received: (qmail 1710 invoked by uid 399); 14 Mar 2010 04:57:03 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 14 Mar 2010 04:57:03 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4B9C6C9E.3070902@FreeBSD.org> Date: Sat, 13 Mar 2010 20:57:02 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.1.7) Gecko/20100218 Thunderbird/3.0.1 MIME-Version: 1.0 To: Wesley Shields References: <201003140407.o2E47fhJ063684@repoman.freebsd.org> In-Reply-To: <201003140407.o2E47fhJ063684@repoman.freebsd.org> X-Enigmail-Version: 1.0.1 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, Bernhard Froehlich , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/redmine Makefile ports/www/redmine/files redmine.in X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Mar 2010 04:57:05 -0000 On 03/13/10 20:07, Wesley Shields wrote: > wxs 2010-03-14 04:07:41 UTC > > FreeBSD ports repository > > Modified files: > www/redmine Makefile > Added files: > www/redmine/files redmine.in > Log: > - Add RC script. > > PR: ports/144299 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=144299 > Submitted by: Bernhard Froehlich (maintainer) > > Revision Changes Path > 1.8 +6 -0 ports/www/redmine/Makefile > 1.1 +32 -0 ports/www/redmine/files/redmine.in (new) > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/redmine/Makefile.diff?&r1=1.7&r2=1.8&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/redmine/files/redmine.in There are several problems with this script. 1. The REQUIRE line needs to be changed to LOGIN. This is preferred for all local scripts, but mandatory for those which run with a non-root [ug]id (which this one does). 2. Instead of command=%%RUBY_NAME%% it's likely you want to use command_interpreter instead. Does the stop command work with this script as it is currently? 3. _flags should not be included in command_args, it will result in them being included twice. 4. Are all of the options included in _flags actually things that a user might wish to twiddle? Should some of them be in command_args instead? 5. The pidfile location looks dubious to me, but I'm not sure if putting pid files in WWWDIR has somehow become routine? 6. And finally a minor issue, %%RC_SUBR%% should just be /etc/rc.subr. I'll be making that change for all ports once the ports freeze is over, so no reason not to do it now. Doug -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/