Date: Sun, 2 Jan 2011 19:21:45 -0800 (PST) From: "Pedro F. Giffuni" <giffunip@tutopia.com> To: freebsd-fs@FreeBSD.org, Doug Barton <dougb@FreeBSD.org> Subject: Re: ext2fs: PR 153584, prealloc, etc. Message-ID: <352778.3837.qm@web113503.mail.gq1.yahoo.com>
next in thread | raw e-mail | index | archive | help
--0-1773603869-1294024905=:3837 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Hello;=0A=0A--- On Sun, 1/2/11, Doug Barton <dougb@FreeBSD.org> wrote:=0A= =0A> From: Doug Barton <dougb@FreeBSD.org>=0A> Subject: ext2fs: PR 153584, = prealloc, etc.=0A> To: freebsd-fs@FreeBSD.org=0A> Cc: "Pedro F. Giffuni" <g= iffunip@tutopia.com>, "Aditya Sarawgi" <sarawgi.aditya@gmail.com>=0A> Date:= Sunday, January 2, 2011, 9:45 PM=0A> Howdy,=0A> =0A> Pedro,=0A> =0A> Thank= s for http://www.freebsd.org/cgi/query-pr.cgi?pr=3D153584=0A>; however it do= es not compile on HEAD:=0A> =0A> cc -O2 -pipe -g -fno-strict-aliasing -Werr= or -D_KERNEL=0A> -DKLD_MODULE=0A> -nostdinc=A0=A0=A0-DHAVE_KERNEL_OPTION_HE= ADERS=0A> -include=0A> /usr/local/obj/home/svn/head/sys/GENERIC/opt_global.= h -I.=0A> -I@ -I@/contrib/altq -finline-limit=3D8000 --param=0A> inline-uni= t-growth=3D100 --param large-function-growth=3D1000=0A> -fno-common -g -g -= fno-omit-frame-pointer=0A> -I/usr/local/obj/home/svn/head/sys/GENERIC -mcmo= del=3Dkernel=0A> -mno-red-zone=A0 -mfpmath=3D387 -mno-sse -mno-sse2=0A> -mn= o-sse3 -mno-mmx -mno-3dnow=A0 -msoft-float=0A> -fno-asynchronous-unwind-tab= les -ffreestanding=0A> -fstack-protector -std=3Diso9899:1999 -fstack-protec= tor -Wall=0A> -Wredundant-decls -Wnested-externs -Wstrict-prototypes=0A> -W= missing-prototypes -Wpointer-arith -Winline=0A> -Wcast-qual=A0 -Wundef -Wno= -pointer-sign=0A> -fformat-extensions -c=0A> /home/svn/head/sys/modules/ext= 2fs/../../fs/ext2fs/ext2_subr.c=0A> /home/svn/head/sys/modules/ext2fs/../..= /fs/ext2fs/ext2_subr.c:=0A> In function 'ext2_checkoverlap':=0A> /home/svn/= head/sys/modules/ext2fs/../../fs/ext2fs/ext2_subr.c:108:=0A> error: derefer= encing pointer to incomplete type=0A> *** Error code 1=0A> =0A> Stop in /ho= me/svn/head/sys/modules/ext2fs.=0A> *** Error code 1=0A> =0A=0AThanks for t= he bug report. This will be very easy to fix and I don't know why I didn't = see it here. but for now use this simpler patch.=0A=0A> =0A> Any chance you= 2 could work together to come up with 1=0A> patch that has the best of bot= h worlds, and actually=0A> compiles on HEAD? It would also be really useful= if the=0A> resultant patch was created using 'svn diff' as it would be=0A>= a lot easier for those of us who are interested in testing=0A> this to do = so, not to mention actually getting it=0A> committed.=0A> =0A=0AWe have bee= n working together with Zheng Liu, who did the=0Apreallocation patch, but I= believe these fixes should come=0Afirst.=0A=0AThanks for testing!=0A=0APed= ro.=0A=0A=0A --0-1773603869-1294024905=:3837 Content-Type: application/octet-stream; name=patch-bde Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=patch-bde ZGlmZiAtcnUgZXh0MmZzLm9yaWcvZXh0Ml9hbGxvYy5jIGV4dDJmcy9leHQy X2FsbG9jLmMKLS0tIGV4dDJmcy5vcmlnL2V4dDJfYWxsb2MuYwkyMDEwLTEy LTI5IDE1OjE0OjA2LjAwMDAwMDAwMCArMDAwMAorKysgZXh0MmZzL2V4dDJf YWxsb2MuYwkyMDEwLTEyLTMwIDIxOjQ1OjU4LjAwMDAwMDAwMCArMDAwMApA QCAtNTksNiArNTksNyBAQAogCQkJCQkJaW50KSk7CiBzdGF0aWMgZGFkZHJf dAlleHQyX25vZGVhbGxvY2NnKHN0cnVjdCBpbm9kZSAqLCBpbnQsIGRhZGRy X3QsIGludCk7CiBzdGF0aWMgZGFkZHJfdCAgZXh0Ml9tYXBzZWFyY2goc3Ry dWN0IG1fZXh0MmZzICosIGNoYXIgKiwgZGFkZHJfdCk7CisKIC8qCiAgKiBB bGxvY2F0ZSBhIGJsb2NrIGluIHRoZSBmaWxlIHN5c3RlbS4KICAqCkBAIC0x MTYsNiArMTE3LDEwIEBACiAgICAgICAgIGJubyA9IChkYWRkcl90KWV4dDJf aGFzaGFsbG9jKGlwLCBjZywgYnByZWYsIGZzLT5lMmZzX2JzaXplLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGV4dDJfYWxsb2NjZyk7CiAgICAgICAgIGlmIChibm8gPiAwKSB7CisJCS8q IHNldCBuZXh0X2FsbG9jIGZpZWxkcyBhcyBkb25lIGluIGJsb2NrX2dldGJs ayAqLworCQlpcC0+aV9uZXh0X2FsbG9jX2Jsb2NrID0gbGJuOworCQlpcC0+ aV9uZXh0X2FsbG9jX2dvYWwgPSBibm87CisKICAgICAgICAgICAgICAgICBp cC0+aV9ibG9ja3MgKz0gYnRvZGIoZnMtPmUyZnNfYnNpemUpOwogICAgICAg ICAgICAgICAgIGlwLT5pX2ZsYWcgfD0gSU5fQ0hBTkdFIHwgSU5fVVBEQVRF OwogICAgICAgICAgICAgICAgICpibnAgPSBibm87CkBAIC02MjUsNyArNjMw LDcgQEAKIAlzdHJ1Y3QgbV9leHQyZnMgKmZzOwogCXN0cnVjdCBidWYgKmJw OwogCXN0cnVjdCBleHQybW91bnQgKnVtcDsKLQlpbnQgZXJyb3IsIGJubywg c3RhcnQsIGVuZCwgbG9jOworCWludCBlcnJvciwgYm5vOwogCWNoYXIgKmJi cDsKIAkvKiBYWFggb25kaXNrMzIgKi8KIAlmcyA9IGlwLT5pX2UyZnM7CkBA IC02NTgsMjYgKzY2Myw3IEBACiAJLyoKIAkgKiBubyBibG9ja3MgaW4gdGhl IHJlcXVlc3RlZCBjeWxpbmRlciwgc28gdGFrZSBuZXh0CiAJICogYXZhaWxh YmxlIG9uZSBpbiB0aGlzIGN5bGluZGVyIGdyb3VwLgotCSAqIGZpcnN0IHRy eSB0byBnZXQgOCBjb250aWdvdXMgYmxvY2tzLCB0aGVuIGZhbGwgYmFjayB0 byBhIHNpbmdsZQotCSAqIGJsb2NrLgogCSAqLwotCWlmIChicHJlZikKLQkJ c3RhcnQgPSBkdG9nZChmcywgYnByZWYpIC8gTkJCWTsKLQllbHNlCi0JCXN0 YXJ0ID0gMDsKLQllbmQgPSBob3dtYW55KGZzLT5lMmZzLT5lMmZzX2ZwZywg TkJCWSkgLSBzdGFydDsKLQlmb3IgKGxvYyA9IHN0YXJ0OyBsb2MgPCBlbmQ7 IGxvYysrKSB7Ci0JCWlmIChiYnBbbG9jXSA9PSAwKSB7Ci0JCQlibm8gPSBs b2MgKiBOQkJZOwotCQkJZ290byBnb3RpdDsKLQkJfQotCX0KLQlmb3IgKGxv YyA9IDA7IGxvYyA8IHN0YXJ0OyBsb2MrKykgewotCQlpZiAoYmJwW2xvY10g PT0gMCkgewotCQkJYm5vID0gbG9jICogTkJCWTsKLQkJCWdvdG8gZ290aXQ7 Ci0JCX0KLQl9CiAKIAlibm8gPSBleHQyX21hcHNlYXJjaChmcywgYmJwLCBi cHJlZik7CiAJaWYgKGJubyA8IDApewo= --0-1773603869-1294024905=:3837--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?352778.3837.qm>