Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 11 Jun 2020 14:04:00 +0000 (UTC)
From:      Alan Somers <asomers@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r538488 - in head/sysutils/smartmontools: . files
Message-ID:  <202006111404.05BE40OW000233@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: asomers (src committer)
Date: Thu Jun 11 14:04:00 2020
New Revision: 538488
URL: https://svnweb.freebsd.org/changeset/ports/538488

Log:
  sysutils/smartmontools: periodic should always alert about failing disks
  
  Periodic scripts should return rc=1 for informational messages.  For matters
  that require urgent attention, then should return rc=3 (or greater).  A
  SMART imminent failure prediction requires urgent attention, so it should
  return rc=3.
  
  PR:		246785
  Approved by:	samm (maintainer timeout)
  Sponsored by:	Axcient

Modified:
  head/sysutils/smartmontools/Makefile
  head/sysutils/smartmontools/files/smart.in

Modified: head/sysutils/smartmontools/Makefile
==============================================================================
--- head/sysutils/smartmontools/Makefile	Thu Jun 11 14:01:25 2020	(r538487)
+++ head/sysutils/smartmontools/Makefile	Thu Jun 11 14:04:00 2020	(r538488)
@@ -3,7 +3,7 @@
 
 PORTNAME=	smartmontools
 PORTVERSION=	7.1
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	sysutils
 MASTER_SITES=	SF
 

Modified: head/sysutils/smartmontools/files/smart.in
==============================================================================
--- head/sysutils/smartmontools/files/smart.in	Thu Jun 11 14:01:25 2020	(r538487)
+++ head/sysutils/smartmontools/files/smart.in	Thu Jun 11 14:04:00 2020	(r538488)
@@ -74,9 +74,9 @@ case "${daily_status_smart_enable}" in
 					${trim_junk} "${tmpfile}"
 				elif [ `grep -c '^SMART support is: Unavailable' ${tmpfile}` -eq 1 ] ; then
 					rc=2
-				echo "N/A"
+					echo "N/A"
 				else
-					rc=1
+					rc=3
 					${smartctl} ${devflags} ${daily_status_smartctl_extra_status_flags} \
 						${device} | ${trim_junk}
 				fi



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202006111404.05BE40OW000233>