From owner-freebsd-ports@freebsd.org Wed Nov 15 18:08:12 2017 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2AA2ADE32C9 for ; Wed, 15 Nov 2017 18:08:12 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EE470741DE; Wed, 15 Nov 2017 18:08:11 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 187D712536; Wed, 15 Nov 2017 18:08:11 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 0931E87B9; Wed, 15 Nov 2017 18:08:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id Pbr-E84rQ0Uo; Wed, 15 Nov 2017 18:08:04 +0000 (UTC) Subject: Re: r450663 (basic flavors) breaks WRKDIRPREFIX='' for complex ports DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com A4D5C87AB To: lev@FreeBSD.org, Mathieu Arnold , "freebsd-ports@freebsd.org" References: <53e15554-9f94-d436-4cfd-6796aaea1833@FreeBSD.org> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <5ed224df-8a69-26d8-4bba-bc6fa53e30a4@FreeBSD.org> Date: Wed, 15 Nov 2017 10:07:48 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <53e15554-9f94-d436-4cfd-6796aaea1833@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Ih06mt5gvh1NaHrT9pKKi1xPh351WvT0h" X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2017 18:08:12 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Ih06mt5gvh1NaHrT9pKKi1xPh351WvT0h Content-Type: multipart/mixed; boundary="PSPCfu4aKhmBQO4QLDGDIfhwA1tScRoWb"; protected-headers="v1" From: Bryan Drewery To: lev@FreeBSD.org, Mathieu Arnold , "freebsd-ports@freebsd.org" Message-ID: <5ed224df-8a69-26d8-4bba-bc6fa53e30a4@FreeBSD.org> Subject: Re: r450663 (basic flavors) breaks WRKDIRPREFIX='' for complex ports References: <53e15554-9f94-d436-4cfd-6796aaea1833@FreeBSD.org> In-Reply-To: <53e15554-9f94-d436-4cfd-6796aaea1833@FreeBSD.org> --PSPCfu4aKhmBQO4QLDGDIfhwA1tScRoWb Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 11/15/2017 6:47 AM, Lev Serebryakov wrote: >=20 > I have WRKDIRPREFIX set to /usr/local/build/ports in /etc/make.conf. >=20 > when I want to test port changes in my home directory I'm using >=20 > % make WRKDIRPREFIX=3D'' check-plist > ... >=20 > It worked for me till r450663 every time and for every port. For > example, it worked for 'devel/subversion': >=20 > % pwd > /usr/home/lev/FreeBSD/ports.local/devel/subversion > % svnversion > 450662 > % make DISABLE_VULNERABILITIES=3Dyes WRKDIRPREFIX=3D'' >=20 > You can have the repository created for you by defining > WITH_REPOSITORY_CREATION. >=20 > Make sure that: > * all your svn users are members of a common group > * this group is the group id of the db/ and locks/ > subdirectories of your repository > * the above subdirectories are writable by this group >=20 > Many useful scripts will be installed into /usr/local/share/subversion > =3D=3D=3D> License APACHE20 accepted by the user > =3D=3D=3D> subversion-1.9.7 depends on file: /usr/local/sbin/pkg - fo= und > =3D=3D=3D> Fetching all distfiles required by subversion-1.9.7 for buil= ding > =3D=3D=3D> Extracting for subversion-1.9.7 > =3D> SHA256 Checksum OK for subversion19/subversion-1.9.7.tar.bz2. > ^C*** Signal 2 > *** Signal 2 > % >=20 > But after r450663 it breaks: >=20 > % cd ../.. > % svn up -r 450663 > Updating '.': > U Mk/Scripts/depends-list.sh > UU Mk/Scripts/do-depends.sh > U Mk/bsd.port.mk > Updated to revision 450663. > % cd devel/subversion > % rm -rf work > % make DISABLE_VULNERABILITIES=3Dyes WRKDIRPREFIX=3D'' > make[1]: don't know how to make > /usr/home/lev/FreeBSD/ports.local/devel/subversion/work/.stage_done.sub= version._usr_local. > Stop >=20 > make[1]: stopped in /usr/home/lev/FreeBSD/ports.local/devel/subversion > *** Error code 2 >=20 > Stop. > make: stopped in /usr/home/lev/FreeBSD/ports.local/devel/subversion > % >=20 First, using "WRKDIRPREFIX=3D''" doesn't seem like a "supported feature".= If there's docs or a specific commit to support such a thing then sure. However, It seems fine to me. > ~/svn/ports/devel/subversion # WRKDIRPREFIX=3D/usr/local/ports make -V = WRKDIR > /usr/local/ports/root/svn/ports/devel/subversion/work > ~/svn/ports/devel/subversion # WRKDIRPREFIX=3D/usr/local/ports make -V = WRKDIR WRKDIRPREFIX=3D > /root/svn/ports/devel/subversion/work > ~/svn/ports/devel/subversion # WRKDIRPREFIX=3D/usr/local/ports make -V = WRKDIR WRKDIRPREFIX=3D'' > /root/svn/ports/devel/subversion/work Given it is just prepended onto WRKDIR I see no reason it would be different with the FLAVORS work; the code should just work. > ./bsd.port.mk:# WRKDIRPREFIX - The place to root the temporary worki= ng directory > ./bsd.port.mk:# Default: ${WRKDIRPREFIX}${.CU= RDIR}/work > ./bsd.port.mk:WRKDIR?=3D ${WRKDIRPREFIX}${.CURDIR}/${_WRKDIR} --=20 Regards, Bryan Drewery --PSPCfu4aKhmBQO4QLDGDIfhwA1tScRoWb-- --Ih06mt5gvh1NaHrT9pKKi1xPh351WvT0h Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJaDIJ/AAoJEDXXcbtuRpfPAtcIALhxnrqs+ngldFqv9U4LvJhI BLydD3li3nDE4LZZh7+xV17no8ErpWntO7U5/ou6kKb0JzpG2y0OTA7vlRR1fgsU atmNEuL1GgxuR8BB5KW9Bd+JYrPSWo/sVZhIitkXd4Ox/1MnqiwUd4HkVLXBt6C6 2I+UhfzD2w1r7W/Mz0dB5C/X6FBPLpSUpv8vaqOj1DD4d9r23T8VD3w5laKN8UAl ky78aT9r7ubglidRBPfUH/9NyJlu3t1vV61JDbSVuobk691FKV9dOMR2uGH0D3LW 1v08LqNdFyfLe5h4n5rYZn6iuPLyxGuY+ZsQXTiOMYLyVgWY2ndMGEVLoJZzklE= =0WpZ -----END PGP SIGNATURE----- --Ih06mt5gvh1NaHrT9pKKi1xPh351WvT0h--