From owner-svn-src-all@FreeBSD.ORG Tue Jul 21 04:33:01 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E6C031065670; Tue, 21 Jul 2009 04:33:01 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85]) by mx1.freebsd.org (Postfix) with ESMTP id C231A8FC08; Tue, 21 Jul 2009 04:33:01 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1]) by dragon.nuxi.org (8.14.3/8.14.3) with ESMTP id n6L48Aks085162; Mon, 20 Jul 2009 21:08:10 -0700 (PDT) (envelope-from obrien@dragon.nuxi.org) Received: (from obrien@localhost) by dragon.nuxi.org (8.14.3/8.14.2/Submit) id n6L48Amg085161; Mon, 20 Jul 2009 21:08:10 -0700 (PDT) (envelope-from obrien) Date: Mon, 20 Jul 2009 21:08:10 -0700 From: "David O'Brien" To: John Baldwin Message-ID: <20090721040810.GA84807@dragon.NUXI.org> References: <200907142046.n6EKkJwO070823@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200907142046.n6EKkJwO070823@svn.freebsd.org> X-Operating-System: FreeBSD 8.0-CURRENT X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? User-Agent: Mutt/1.5.16 (2007-06-09) Cc: svn-src-stable@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, svn-src-stable-7@FreeBSD.org Subject: Re: svn commit: r195696 - in stable/7: crypto/openssh secure/lib/libssh X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2009 04:33:02 -0000 On Tue, Jul 14, 2009 at 08:46:19PM +0000, John Baldwin wrote: > Date: Tue Jul 14 20:46:19 2009 > New Revision: 195696 > URL: http://svn.freebsd.org/changeset/base/195696 > Log: > MFC: Use the closefrom(2) system call. > Modified: > stable/7/crypto/openssh/ (props changed) > stable/7/crypto/openssh/config.h > stable/7/crypto/openssh/ssh_namespace.h > stable/7/secure/lib/libssh/ (props changed) > stable/7/secure/lib/libssh/Makefile Hi John, Would you mind backing out this commit from 7-stable. This change mades it so one cannot seriously boot a machine multiuser with an older kernel as /usr/sbin/sshd dies due to bad system call. I think the MFC of this part of the closefrom(2) addtion edge up against POLA for a mature -stable branch. Even in -CURRENT it's good form to add a new system call and then immedately use it... without some time laps to allow folks to boot a week old kernel. Thanks, -- David