From owner-freebsd-bugs@FreeBSD.ORG Sun Jul 20 13:10:02 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9110837B401 for ; Sun, 20 Jul 2003 13:10:02 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6780943FB1 for ; Sun, 20 Jul 2003 13:10:01 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h6KKA1Up078716 for ; Sun, 20 Jul 2003 13:10:01 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h6KKA1bG078715; Sun, 20 Jul 2003 13:10:01 -0700 (PDT) Resent-Date: Sun, 20 Jul 2003 13:10:01 -0700 (PDT) Resent-Message-Id: <200307202010.h6KKA1bG078715@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Lukas Ertl Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1FEEB37B401 for ; Sun, 20 Jul 2003 13:06:36 -0700 (PDT) Received: from mailbox.univie.ac.at (mail.univie.ac.at [131.130.1.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8B04B43FBD for ; Sun, 20 Jul 2003 13:06:34 -0700 (PDT) (envelope-from le@univie.ac.at) Received: from korben.in.tern (adslle.cc.univie.ac.at [131.130.102.11]) by mailbox.univie.ac.at (8.12.2/8.12.2) with ESMTP id h6KK6HMJ045976 for ; Sun, 20 Jul 2003 22:06:23 +0200 Received: from korben.in.tern (korben.in.tern [127.0.0.1]) by korben.in.tern (8.12.9/8.12.9) with ESMTP id h6KK62q9015251 for ; Sun, 20 Jul 2003 22:06:03 +0200 (CEST) (envelope-from le@korben.in.tern) Received: (from le@localhost) by korben.in.tern (8.12.9/8.12.9/Submit) id h6KK62li015250; Sun, 20 Jul 2003 22:06:02 +0200 (CEST) (envelope-from le) Message-Id: <200307202006.h6KK62li015250@korben.in.tern> Date: Sun, 20 Jul 2003 22:06:02 +0200 (CEST) From: Lukas Ertl To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: bin/54672: [PATCH] fix gcc 3.3 compiler warning for ifconfig(8) X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Lukas Ertl List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jul 2003 20:10:03 -0000 >Number: 54672 >Category: bin >Synopsis: [PATCH] fix gcc 3.3 compiler warning for ifconfig(8) >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Jul 20 13:10:00 PDT 2003 >Closed-Date: >Last-Modified: >Originator: Lukas Ertl >Release: FreeBSD 5.1-CURRENT i386 >Organization: Vienna University Computer Center >Environment: System: FreeBSD korben 5.1-CURRENT FreeBSD 5.1-CURRENT #4: Mon Jul 14 22:28:43 CEST 2003 le@korben:/usr/obj/usr/src/sys/KORBEN i386 >Description: When compiling ifconfig(8), gcc-3.3 emits the following warning: cc -O -pipe -march=athlon -DUSE_IF_MEDIA -DINET6 -DUSE_VLANS -DUSE_IEEE80211 -DUSE_MAC -DNS -Wall -Wmissing-prototypes -Wcast-qual -Wwrite-strings -Wnested-externs -I.. -DRESCUE -c /usr/src/sbin/ifconfig/ifconfig.c /usr/src/sbin/ifconfig/ifconfig.c: In function `setatrange': /usr/src/sbin/ifconfig/ifconfig.c:1692: warning: comparison is always false due to limited range of data type /usr/src/sbin/ifconfig/ifconfig.c:1692: warning: comparison is always false due to limited range of data type The bogus comparison is: if (sscanf(range, "%hu-%hu", &first, &last) != 2 || first == 0 || first > 0xffff || last == 0 || last > 0xffff || first > last) first and last are both declared as u_short, which can't hold values larger then 0xffff, so the comparison isn't needed. >How-To-Repeat: >Fix: --- ifconfig.diff begins here --- Index: sbin/ifconfig/ifconfig.c =================================================================== RCS file: /usr/local/bsdcvs/src/sbin/ifconfig/ifconfig.c,v retrieving revision 1.90 diff -u -u -r1.90 ifconfig.c --- sbin/ifconfig/ifconfig.c 28 Apr 2003 16:37:38 -0000 1.90 +++ sbin/ifconfig/ifconfig.c 20 Jul 2003 20:01:02 -0000 @@ -1688,8 +1688,7 @@ u_short first = 123, last = 123; if (sscanf(range, "%hu-%hu", &first, &last) != 2 - || first == 0 || first > 0xffff - || last == 0 || last > 0xffff || first > last) + || first == 0 || last == 0 || first > last) errx(1, "%s: illegal net range: %u-%u", range, first, last); at_nr.nr_firstnet = htons(first); at_nr.nr_lastnet = htons(last); --- ifconfig.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: