From owner-svn-src-head@FreeBSD.ORG  Mon Nov  9 18:20:38 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 938021065676;
	Mon,  9 Nov 2009 18:20:38 +0000 (UTC)
	(envelope-from nwhitehorn@freebsd.org)
Received: from mail.icecube.wisc.edu (trout.icecube.wisc.edu [128.104.255.119])
	by mx1.freebsd.org (Postfix) with ESMTP id 19F7D8FC16;
	Mon,  9 Nov 2009 18:20:38 +0000 (UTC)
Received: from localhost (localhost.localdomain [127.0.0.1])
	by mail.icecube.wisc.edu (Postfix) with ESMTP id 74C8E581BD;
	Mon,  9 Nov 2009 12:20:37 -0600 (CST)
X-Virus-Scanned: amavisd-new at icecube.wisc.edu
Received: from mail.icecube.wisc.edu ([127.0.0.1])
	by localhost (trout.icecube.wisc.edu [127.0.0.1]) (amavisd-new,
	port 10030)
	with ESMTP id 7lkeJiFUy2KQ; Mon,  9 Nov 2009 12:20:37 -0600 (CST)
Received: from wanderer.tachypleus.net (i3-dhcp-172-16-55-200.icecube.wisc.edu
	[172.16.55.200])
	by mail.icecube.wisc.edu (Postfix) with ESMTP id 55DC758176;
	Mon,  9 Nov 2009 12:20:37 -0600 (CST)
Message-ID: <4AF85D75.1010605@freebsd.org>
Date: Mon, 09 Nov 2009 12:20:37 -0600
From: Nathan Whitehorn <nwhitehorn@freebsd.org>
User-Agent: Thunderbird 2.0.0.23 (X11/20090909)
MIME-Version: 1.0
To: Alexander Motin <mav@FreeBSD.org>
References: <200911091139.nA9BdpAU019880@svn.freebsd.org>
In-Reply-To: <200911091139.nA9BdpAU019880@svn.freebsd.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r199079 - head/sbin/camcontrol
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Nov 2009 18:20:38 -0000

Alexander Motin wrote:
> Author: mav
> Date: Mon Nov  9 11:39:51 2009
> New Revision: 199079
> URL: http://svn.freebsd.org/changeset/base/199079
>
> Log:
>   Add support for ATA Power Management.
>
> Modified:
>   head/sbin/camcontrol/camcontrol.8
>   head/sbin/camcontrol/camcontrol.c
>   
[...]
> +static int
> +atapm(struct cam_device *device, int argc, char **argv,
> +		 char *combinedopt, int retry_count, int timeout)
> +{
> +	union ccb *ccb;
> +	int retval = 0;
> +	int t = -1;
> +	char c;
>
>   
[...]
> +
> +	while ((c = getopt(argc, argv, combinedopt)) != -1) {
> +		switch (c) {
> +		case 't':
> +			t = atoi(optarg);
> +			break;
> +		default:
> +			break;
> +		}
> +	}
This broke world on PowerPC, where char is unsigned. Could you change 
the type of c to int, or explicitly mark it signed?
-Nathan