Date: Sun, 16 May 2010 03:04:29 GMT From: Emil Smolenski <ambsd@raisa.eu.org> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/146626: [PATCH] print/hplip3 gzip files curruption with USE_DOS2UNIX=yes Message-ID: <201005160304.o4G34TL7007297@www.freebsd.org> Resent-Message-ID: <201005160310.o4G3A2fH084271@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 146626
>Category: ports
>Synopsis: [PATCH] print/hplip3 gzip files curruption with USE_DOS2UNIX=yes
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun May 16 03:10:02 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Emil Smolenski
>Release: FreeBSD 8.0-STABLE
>Organization:
>Environment:
FreeBSD bolt 8.0-STABLE FreeBSD 8.0-STABLE #10: Thu May 13 17:29:11 CEST 2010 root@bolt:/usr/obj/usr/src/sys/BOLT i386
>Description:
The print/hplip3 port installs corrupted gzip files. It makes this software almost unusable:
- many PPD files are corrupted,
- it is impossible to print test page.
>How-To-Repeat:
1. Install print/hplip3.
2. Try to print test page with hp-testpage. It fails.
$ cd /usr/local/share/hplip/data/ps/
$ gzip -t testpage.ps.gz
gzip: invalid compressed data--crc error
gzip: testpage.ps.gz: uncompress failed
>Fix:
Define proper DOS2UNIX_REGEX in Makefile (patch is attached). I think PORTREVISION should be bumped.
Patch attached with submission follows:
diff -ruN /usr/ports/print/hplip3.orig/Makefile /usr/ports/print/hplip3/Makefile
--- /usr/ports/print/hplip3.orig/Makefile 2010-05-14 13:43:23.000000000 +0200
+++ /usr/ports/print/hplip3/Makefile 2010-05-16 03:53:37.126496801 +0200
@@ -48,6 +48,7 @@
MAKE_JOBS_SAFE= yes
SUB_FILES= pkg-message
USE_DOS2UNIX= yes
+DOS2UNIX_REGEX=.+\.(c|cpp|h|py)$
DOCSDIR= ${PREFIX}/share/doc/${PORTNAME}-${PORTVERSION}
CPPFLAGS+= -I${LOCALBASE}/include
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201005160304.o4G34TL7007297>