From owner-freebsd-gnome@FreeBSD.ORG Tue Nov 25 19:43:44 2014 Return-Path: Delivered-To: gnome@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8F988CA1; Tue, 25 Nov 2014 19:43:44 +0000 (UTC) Received: from mail-yk0-x22b.google.com (mail-yk0-x22b.google.com [IPv6:2607:f8b0:4002:c07::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 44AE3CD7; Tue, 25 Nov 2014 19:43:44 +0000 (UTC) Received: by mail-yk0-f171.google.com with SMTP id 142so597302ykq.2 for ; Tue, 25 Nov 2014 11:43:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=iamI7UCWO4LYd34zyAiM+UlQVjpWBlICmS2akahx2qs=; b=Er/aHk0t7sZPOl5CII+HwNpVs7kS7KrPg/Z/gMCoDDgBhZrQXfIM/7DlwCuaLNB+Se 3ggroufMUVEnmcwckWqOHqaDKTWbZtHwOY30VdO9i/7AL3YZ21NNMiyRDobAw0g4mhSX RVIuR95MFFdBXgQacxAIYtuRmtiIecxTSnyoZ+h9DCqqYqnvl6LUsGRsNowHSw5md1XH qaWh0VsTQm7oJPQ0KQMt4h8uYjAKAYXFLH6DchmLuqUNYPW380Fe81Con6CBVApDZ3M7 dLMgJk88T6yYG4ejqKaS3osZOkVzohwyFhRLIjLvOgahZ+MvJ8FNfHpsh27nvEDAAKLd sGZQ== MIME-Version: 1.0 X-Received: by 10.170.191.137 with SMTP id i131mr29747897yke.100.1416944623325; Tue, 25 Nov 2014 11:43:43 -0800 (PST) Sender: antoine.brodin.freebsd@gmail.com Received: by 10.170.211.9 with HTTP; Tue, 25 Nov 2014 11:43:43 -0800 (PST) In-Reply-To: <20141125080248.GA1026@medusa.sysfault.org> References: <20140916124035.2217ba67f72bce56e56eb677@3dresearch.com> <546F767B.4070702@missouri.edu> <20141125080248.GA1026@medusa.sysfault.org> Date: Tue, 25 Nov 2014 20:43:43 +0100 X-Google-Sender-Auth: uHLzCYSvBLImoAM7RURg7is_GeI Message-ID: Subject: Re: /usr/ports/devel/py-gobject3: typo? From: Antoine Brodin To: Marcus von Appen Content-Type: multipart/mixed; boundary=001a11c11480f0de090508b42046 Cc: "Montgomery-Smith, Stephen" , "gnome@FreeBSD.org" , Janos Dohanics X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Nov 2014 19:43:44 -0000 --001a11c11480f0de090508b42046 Content-Type: text/plain; charset=UTF-8 On Tue, Nov 25, 2014 at 9:02 AM, Marcus von Appen wrote: > On, Tue Nov 25, 2014, Antoine Brodin wrote: > >> On Tue, Nov 25, 2014 at 5:38 AM, Jia-Shiun Li wrote: >> > See if this is helpful to you.. >> > >> > I encountered this in the middle of building gnome3-lite. On my case >> > py-gobject3 builds fine alone but fails if built as dependency. >> > >> > When failing, there is no >> > pygobject-3.14.0-py2.7-freebsd-11.0-CURRENT-amd64.egg-info >> > as requested in install phase, but there does have >> > pygobject-3.14.0-pypython2.7-freebsd-11.0-CURRENT-amd64.egg-info >> > in the directory. looks something messed up PYTHON_VER for plist. >> > >> > >> > The easier way to reproduce is >> > cd /usr/ports/accessibility/caribou && make >> > vs. >> > cd /usr/ports/devel/py-gobject3 && make install >> > >> > config.log files from both do not differ. It is more likely 'make >> > install' causing the problem. >> > >> > >> > My temporary workaround is to rename the file as plist required and continue. >> >> Hi mva@, >> >> Could you have a look at this? >> I believe that the DEPENDS_ARGS+=PYTHON_VERSION=${PYTHON_VERSION} in >> python.mk can cause this kind of issue for some autoconf based >> projects. >> In python.mk, PYTHON_VERSION=python2.7, but in some autoconf based >> projects PYTHON_VERSION=2.7 (${PYTHON} -c "import sys; >> sys.stdout.write(sys.version[:3])" 2>/dev/null) >> So the DEPEND_ARGS may pollute the build of dependencies... > > Yes, it looks like DEPENDS_ARGS is the culprit here. The conditionals > within the configure script of pygobject3-common can run into > situations, where they do not override PYTHON_VERSION properly. > > We have two ways around that: > > - override PYTHON_VERSION in the individual ports, which break that way > - quickly done > - has to be done on a port-per-port basis > - adds another "hack" to maintain per port > - rename PYTHON_VERSION in the ports infrastructure to something else > - more clean approach(?) > - not done quickly > - may affect users using PYTHON_VERSION actively > - may need other ports to receive additional changes > - needs a full exp-run (without isolations, so poudriere is a no-op) > > As workaround, I'd go with the first option for now. Depending on how > the gnome stuff evolves, we may need to look into option two as well. The attached patch is ugly, but it seems to work. I agree that long term solution would be to use variable names that don't pollute ports build in DEPENDS_ARGS. Cheers, Antoine --001a11c11480f0de090508b42046 Content-Type: text/plain; charset=US-ASCII; name="pg3.diff" Content-Disposition: attachment; filename="pg3.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i2xo625i1 SW5kZXg6IGRldmVsL3B5LWdvYmplY3QzL01ha2VmaWxlCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGRldmVsL3B5 LWdvYmplY3QzL01ha2VmaWxlCShyZXZpc2lvbiAzNzM0MjQpCisrKyBkZXZlbC9weS1nb2JqZWN0 My9NYWtlZmlsZQkod29ya2luZyBjb3B5KQpAQCAtMTEsNSArMTEsNyBAQAogCiBNQVNURVJESVI9 CSR7LkNVUkRJUn0vLi4vLi4vZGV2ZWwvcHlnb2JqZWN0My1jb21tb24KIFBMSVNUPQkJJHsuQ1VS RElSfS9wa2ctcGxpc3QKKyMgT3ZlcnJpZGUgUFlUSE9OX1ZFUlNJT04gZnJvbSBERVBFTkRTX0FS R1MKK01BS0VfQVJHUz0JUFlUSE9OX1ZFUlNJT049JHtQWVRIT05fVkVSfQogCiAuaW5jbHVkZSAi JHtNQVNURVJESVJ9L01ha2VmaWxlIgo= --001a11c11480f0de090508b42046--