From owner-freebsd-bugs Wed Aug 19 23:50:09 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id XAA03942 for freebsd-bugs-outgoing; Wed, 19 Aug 1998 23:50:09 -0700 (PDT) (envelope-from owner-freebsd-bugs@FreeBSD.ORG) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id XAA03899 for ; Wed, 19 Aug 1998 23:50:05 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id XAA00316; Wed, 19 Aug 1998 23:50:01 -0700 (PDT) Date: Wed, 19 Aug 1998 23:50:01 -0700 (PDT) Message-Id: <199808200650.XAA00316@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.ORG From: Max Gotlib Subject: Re: kern/7144: WaveLAN interface moves packets to uper layer while dst addr does not belong to that interface (even while not in allmulti/promisc mode) Reply-To: Max Gotlib Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org The following reply was made to PR kern/7144; it has been noted by GNATS. From: Max Gotlib To: Greg Troxel Cc: freebsd-gnats-submit@freebsd.org, Jim Binkley , Mike Smith Subject: Re: kern/7144: WaveLAN interface moves packets to uper layer while dst addr does not belong to that interface (even while not in allmulti/promisc mode) Date: Thu, 20 Aug 1998 12:55:39 +0600 (ESD) Hi! Glad too see that wavelan technology is of a particular interest ... And as for suggested patch - totally agreed :))) And one Q. more - I sent another patch (kern/7044) that fixed (at least for me) wavelan board initialization process... Can you test it on your board, please, and if the results will be successfull - i would be glad to see it (or it's variant) in the FreeBSD source tree... With best regards, Max. On Wed, 19 Aug 1998, Greg Troxel wrote: > I had just about the same problem, with 915 MHz ISA wavelans cards and > no wavepoints. Running mrouted, which set IFF_ALLMULTI caused unicast > packets with a mac address not matching the local machine to be > forwarded. My fix is different, and I believe makes bpf work > correctly. > > The check for dropping unicast packets not sent to our ethernet > address is after the bpf tap, but not conditioned on it. All packets > received should get handed to bpf, and unicast packets not to us (mac) > should get dropped whether or not there is a bpf listener. I believe > that the common optimization that the interface is in hw promisc mode > iff there is a bpf listener is in general wrong, but more frequently > so on wavelans. > > I think Max's fix makes bpf listeners not see unicast packets sent to > others, but I'm not sure. > > One can argue that checking on MOD_ENAL is wrong, but the code only > drops packets that shouldn't be received. The correctness condition > is that it be run whenever unicast packets without our mac address can > be received. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message