From owner-freebsd-gnome@freebsd.org Mon Jan 18 10:00:38 2016 Return-Path: Delivered-To: freebsd-gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9E0FCA85E24 for ; Mon, 18 Jan 2016 10:00:38 +0000 (UTC) (envelope-from kubito@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 764F81D84 for ; Mon, 18 Jan 2016 10:00:38 +0000 (UTC) (envelope-from kubito@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 7399FA85E1D; Mon, 18 Jan 2016 10:00:38 +0000 (UTC) Delivered-To: gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5AF1BA85E19; Mon, 18 Jan 2016 10:00:38 +0000 (UTC) (envelope-from kubito@gmail.com) Received: from mail-wm0-x234.google.com (mail-wm0-x234.google.com [IPv6:2a00:1450:400c:c09::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E70651D7E; Mon, 18 Jan 2016 10:00:37 +0000 (UTC) (envelope-from kubito@gmail.com) Received: by mail-wm0-x234.google.com with SMTP id u188so96792178wmu.1; Mon, 18 Jan 2016 02:00:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=CuOYza9hG7uNWQT9AWaoiDJlJuxsD0+AAeFwGbC0mQ8=; b=OJdx1xMhOCbgxaBgIUcxmHZqVulu0jGTJhcsfPjiU4aYgPCz4pnkr9q6TwiILKXn59 2F5Xv7kf/JXCWVYKmEpuGPhVjJQ0gyOnTFbY+IK8DDQYMu8SCoB6cAc8E4WCwRHgLIEg a5YVPTX0OV0pnlHEmeshTAZP96qwcseLniwyca2ek+3L+olIMNEjvosLTlj4gyOyCNVU yUdAai/+IgI4obpwCepTkkSGQqOTJ7btdmB9hFfFhQp5NBLbNrstI7/ceL2C5ZpPCFz2 r2cMDRv6ejujLP19gARfhB3M0UwTi2yCbf+6JczqcUq49ibZKZwiybXjGlSO8yCz8lWF ZUPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version:content-type; bh=CuOYza9hG7uNWQT9AWaoiDJlJuxsD0+AAeFwGbC0mQ8=; b=BjZ2dc7RMCHjvGET60EK5ZPC9TB1leQ73SVBuDXNi8iFArZnni6LNjF9alknpw6qJy QwrTb6k/O7hgh+UA4O2ZmRgvBgdaGcRfjQoMVPzquieoLjhg1A0PBIwmS7Ugddc4aaaL ct3gOFJGLRZYaUhMhZv49syV4tpqdI46B/OwLWLMhUtptuITJ/9BS2i+dbeumy5HLiKX ygRX7E4dAb7Uh0O6D5v16PgM3+T9b+B/fNgSW2cNcyEXmfZ6IZ50D5Imi+6RZrbvM7FM 1F7gWQh7+eEoJdj8sEN/Po0bmBeKKw6UR1fn/va3E1PUmWTqJSvVQHdqkn2vPRsP0Jzw 2KLg== X-Gm-Message-State: ALoCoQnDG3OCerWo8eV7s9f7DJoK9rjkZtWnFaQtb2ZEK1NBt8sJtffQlY3BedXiZxzXX0g4fJvxWKiG1ZQOGMFhxiTqeD4dsg== X-Received: by 10.194.95.136 with SMTP id dk8mr24135880wjb.96.1453111236518; Mon, 18 Jan 2016 02:00:36 -0800 (PST) Received: from rodolpho.gmail.com ([46.101.211.41]) by smtp.gmail.com with ESMTPSA id m206sm14959134wmf.16.2016.01.18.02.00.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Jan 2016 02:00:35 -0800 (PST) Sender: Raphael Kubo da Costa From: Raphael Kubo da Costa To: Mathieu Arnold Cc: gnome@FreeBSD.org, perl@FreeBSD.org Subject: Re: libperl stage-qa check and libraries that do not link against libperl.so References: <86d1t0nu6x.fsf@FreeBSD.org> <83298B9CC954C7F5642168D0@atuin.in.mat.cc> <868u3nonxn.fsf@FreeBSD.org> <880733D886684E0C0D43E7D8@atuin.in.mat.cc> Date: Mon, 18 Jan 2016 08:00:29 -0200 In-Reply-To: <880733D886684E0C0D43E7D8@atuin.in.mat.cc> (Mathieu Arnold's message of "Mon, 18 Jan 2016 01:28:58 +0100") Message-ID: <8637tvyzpe.fsf@FreeBSD.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jan 2016 10:00:38 -0000 Mathieu Arnold writes: > +--On 17 janvier 2016 23:12:36 +0100 Raphael Kubo da Costa > wrote: > |> For these, if the non-linking is intentional, and not needed, > |> ignore the ***WARNING***. > | > | Right. If linking against libperl.so and not linking against it are both > | fine, does it still make sense to have that stage-qa check? > > There is a stage-qa check because if you link against libperl.so, you MUST > have rpath set to the path of libperl.so, it happens if the port is doing > what Perl should be doing and getting it wrong. Also, sometime, you don't > link with libperl.so, and it's a mistake, and it should be. > > There are a few cases where it's not needed, but when I added the qa check > when I changed libperl.so to be versionned, out of all the ports that > install .so in PERL_ARCH, there were, say, 3 or 4 that had a .so that did > not need to be linked with libperl.so. How about making the "not linked with libperl.so.x.y" warning non-fatal then? Right now I cannot just ignore it as suggested because it makes the script exit with a non-zero error code. While here: there's a FIXME comment in this part that talks about changing the linkage detection logic, but it does not specify what should be changed. Do you have more information? I could try to fix both issues and send a patch for review.