From owner-svn-ports-all@freebsd.org  Sun Dec 24 14:23:48 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 276B2E91EA3;
 Sun, 24 Dec 2017 14:23:48 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 07DC17C896;
 Sun, 24 Dec 2017 14:23:48 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 219773E22; Sun, 24 Dec 2017 14:23:47 +0000 (UTC)
Date: Sun, 24 Dec 2017 14:23:47 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Marcelo Araujo <araujo@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r456964 - in head/audio: . pc-mixer
Message-ID: <20171224142347.GD1693@FreeBSD.org>
References: <201712220249.vBM2nIOU084143@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201712220249.vBM2nIOU084143@repo.freebsd.org>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Dec 2017 14:23:48 -0000

On Fri, Dec 22, 2017 at 02:49:18AM +0000, Marcelo Araujo wrote:
> New Revision: 456964
> URL: https://svnweb.freebsd.org/changeset/ports/456964
> 
> Log:
>   Add pc-mixer version 20171212 part of Lumina desktop version 1.4.1.
>   
>   PR:		ports/224305
>   Submitted by:	JT Pennington <jt@ixsystems.com>
>   Sponsored by:	iXsystems, Inc.

A few observations if you don't mind.

> Added: head/audio/pc-mixer/Makefile
> ...
> @@ -0,0 +1,34 @@
> +# $FreeBSD$
> +
> +PORTNAME=	pc-mixer
> +PORTVERSION=	20171212
> +CATEGORIES=	audio
> +
> +MAINTAINER=	jmaloney@ixsystems.com
> +COMMENT=	QT5 based audio mixer for FreeBSD

QT is abbreviation for QuickTime; the toolkit is called "Qt".

> +MAKE_JOBS_UNSAFE=yes

Please include a reason in the commit log when (un)marking a port as
jobs-unsafe: it would help interested developers to try to fix the
problem.  Short excerpt from the build log showing the failure would
usually suffice.

> +USE_GL+=	gl

Why += here?

> +GH_PROJECT=	pc-mixer

This is the default and should've been dropped.

> Added: head/audio/pc-mixer/pkg-descr
> ...
> @@ -0,0 +1,3 @@
> +TrueOS QT5 based audio mixer
> +
> +WWW: https://github.com/trueos/pc-mixer

Port description should not simply rephrase or copy COMMENT, see Section
3.2.1 of the PHB.  It should also be terminated with a full stop (dot).
QT5 is spelled wrongly as noted above.

./danfe