From owner-freebsd-current@freebsd.org Sun Aug 16 15:42:26 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 07B033BFC04 for ; Sun, 16 Aug 2020 15:42:26 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670076.outbound.protection.outlook.com [40.107.67.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BV1dY0Vn4z4W05 for ; Sun, 16 Aug 2020 15:42:24 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XuigoIM/rnQPJ1bNs4IqnYNuAvpBo7SKJEswnUVL3u0G4ZN4Hc3iQmLTaEHp5GPP8d5Q1gvUmYG6gsyy7s6W4V+jCZ/O4OK8FwidGOiMZYI9bw3Zw0jR9oHQ1vnWvegRRwBOyAQ0LMSrp0GIbcMEg1vmt8QV6iLluGph5PCTPhBy1WwZx9ZbIG2XBw4MIrRXJKiPgVBP+5A/s4exvuO6K+bWUseJAL10CW3xXDWJzRKcLerZt2Yu/oNCOgjk6wDf9F4AUSKdfo4OYfr4uABm9faxM3XpkDy6pky2M65QI8DWVqsghf1m4MLpRC0bc0uG0r8GnMrf5hrt4u5YvUOiGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y+Mj0yX8Md8yV487PU6wzIxBIA6VlRwCxGAWs2Yza/Q=; b=ND8YkOxGkCJbTh3RsJvLS/5pz/ATkO7JqwkU9R4foS5NHx7Od6i9jyIQvYz1hJfnGhqLyFg3DHzToac9+L5B51l+hmdkZZBlmI/Ak4dvTyJDR3czGLWoomXov1VqmC/dI61HbTPeMEnwj3L2O+g0gQQ7OPSElsBMo38pYRd7T2Njgn7lCNtRaky7lB9yDc1NP7WmA14Aot9K2rdp50udEnT7uAhJwW5+XCmvfMAV/an0qrxr9iluc2KYYArZChVa3yeYGPUXhYL3sMcqrtvlzRVFRMwloUy9lMIms7VKbnyJEz1R/MJBAu7iDqEM7bG/MQiGOepfuz1zzwQID1Ab5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none Received: from QB1PR01MB3364.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:38::14) by YQXPR01MB3847.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:42::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.15; Sun, 16 Aug 2020 15:42:23 +0000 Received: from QB1PR01MB3364.CANPRD01.PROD.OUTLOOK.COM ([fe80::e89a:a655:91ca:4e63]) by QB1PR01MB3364.CANPRD01.PROD.OUTLOOK.COM ([fe80::e89a:a655:91ca:4e63%5]) with mapi id 15.20.3283.027; Sun, 16 Aug 2020 15:42:14 +0000 From: Rick Macklem To: "freebsd-current@freebsd.org" Subject: review of a change to sosend_generic() Thread-Topic: review of a change to sosend_generic() Thread-Index: AQHWc+NHhMoQj2hArkGRO65PT+taLQ== Date: Sun, 16 Aug 2020 15:42:14 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 82113675-84be-44a0-9281-08d841faf316 x-ms-traffictypediagnostic: YQXPR01MB3847: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 208+k3VLbkKEP3R2d2RflA4vVQ6e3p9z/Onx6XrwqqahAuFNa8LMEjEoHab8vqBLvM85MeVs/U2h/iVAvzDF8CJQseIzdbSkwPTft4k0X+lO4iSgvPZzE5cGUBDJ1+0WZSvvm+mcJunpB99QREQpUdU+FdNkYqCxn3340erRREWnUbiQ4l+40DddakGZkI7FifhzJesh+jJNZYoPNFPNUHxDVegOFXeFoWygJLujam7yvRxkyBxcokg3TEtyos5qcek3xD14SODX5Vx9v/lgrL6dERWpW0uKin6u3U8XzqF631HiKB5RRFqhel+BkePZztldPBk0pd1iiId7PbZpNL/BedH927smJ2Ri5+zmYVmfkbth8dwDjk33ToVAAxrg x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:QB1PR01MB3364.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(396003)(39850400004)(346002)(376002)(366004)(136003)(9686003)(52536014)(8936002)(33656002)(6916009)(91956017)(66946007)(76116006)(66556008)(66446008)(478600001)(66476007)(64756008)(71200400001)(8676002)(55016002)(2906002)(7696005)(83380400001)(6506007)(786003)(316002)(86362001)(186003)(5660300002)(41533002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: LPvv2zAVZnk9Q+sddkjWDuj6gE323EcvGZrAhlRCyPjVL5FMxIOgNIMXlIfUyBXiBKpAyT0nnBjhOnVz98+qzbpaGhcezVZ0oQxge1E1F/rHUBULdIU7uFN+s6yRvivPqBDwRb0FHlWuIFagE9AVJdmNB+vx7treJZkdnpumGOyG8LUFTwFXFQpLtF8KEcaJ378he1aghCnjQrTP5ubUKoTWadBXWGvGdRBPF9ivpJmMlbl16o6fAAOAtSw+K3Eksr41GReAP11bqJrBGXy59JeK99oP2Ie7Z5m0OV64iRs7n16bbQDJKLQnBL4pmZu2/a8fXItk9lbxTx1nkoSw4QPYsEwRlTSnt/21APRQ7Muy7gGqXAlzaz/wqT2GAXH+vrLlktB6/zDI2ZJz196kUMossCqCts44gPKRIvmls8FbwJACYUWypCzT/8tx3+U1uVHKiW0Sm7nKt/e43oyyO67zx/TLx9w2N+ZHM54z0rMcN4L6A5A4+bOT5K52axczVUAzWCFsAvIyIbEXZsfwd1jOXg5YumtaPnLlT83ePnqGFdDYJtXe2RUZykp9d0Cm/Dbkhia79z7/GX9r/8S8PSwR4N6N1uEFfTe2RmOjFjXQ6vAWraWiWgTBI2KN5QUYAQIA5PgGttlE0zjIHEie/nFC/X4jFiQXrpLV1VK5qHWidj+3QS/SXyF6x+NzRw42e64CCbWuaE7pp0+FyhYKow== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: QB1PR01MB3364.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 82113675-84be-44a0-9281-08d841faf316 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Aug 2020 15:42:14.8117 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7dRZFen7ezVZN2/KC3KxGGZUHeVAk8FRlMUSRgsaBBfH7d5V6doRbnDaBgGqBkvJ1F+TVt6nTbMXcM9VJE0c9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQXPR01MB3847 ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1597592545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding:dkim-signature; bh=Y+Mj0yX8Md8yV487PU6wzIxBIA6VlRwCxGAWs2Yza/Q=; b=UIVONiMjLKL2CqMqOf9rsnbUh/kBYbuBhpypqvt7Z8ATUxXVxhMm1FwnVErjDUBq8EThk6 4hgsh4/wDhzxLe5fqditTYb10m0T3EFGxKeZr8Oc3UEkAjFGs7l3g6XsKla6CevknlR9Se xXV+mFmlsgtrG3+gQFIl0d4vCb2bwfcAWEPWXngTa5isedIPUVE+n4L1gE5CtkC/mVeYV0 phoGdwEy+IB/4LxRKS7I0diWlBR6xq72Qy41ijsOZc7hNV788pR2OdV5svDOlpO+gdjydU YMgO1XF3fpXT4bxh1SjXa31BqvyDlDocT8QOc+yH2jRI8YER2lV9wyUzGh+SHQ== ARC-Seal: i=2; s=dkim; d=freebsd.org; t=1597592545; a=rsa-sha256; cv=pass; b=xCvVpnqKWGkYZ8CYQuiECZ3wJtKe4sg+Eecu1apwfQvYzqa4xFZIR+mlxmKzwitlXZdGsF n2urzNl4OcntgM67gnswlfecudgVD/jAhqaVu/wAx8pKpmxfKP5/BfZmwMLlzmO6l8giEh v8r6m2Hg5OSXqclPDMYkjeDb2R72OLSoVI9p9tEdqzrN5gJ0HTVDLlWSO/i52Y49VQGeGi j9mhfjSKJSWHxQs4pX+57eEG8to+Sjw92BRVgNqE5kTmxO9O2Q9J37brLIf63LXfdozCHX JjciUT6sqOLMspLnoV+JfCYToGNgrTfajnNt3Mj7kMt4MfZmz6kEBvVLFuF9Tg== ARC-Authentication-Results: i=2; freebsd.org; dkim=none (message not signed) header.d=none; freebsd.org; dmarc=none action=none header.from=uoguelph.ca; X-Rspamd-Queue-Id: 4BV1dY0Vn4z4W05 X-Spamd-Bar: ----- X-Spamd-Result: default: False [-5.74 / 15.00]; NEURAL_HAM_MEDIUM(-1.02)[-1.024]; R_DKIM_ALLOW(-0.20)[uoguelph.ca:s=selector1]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; MIME_GOOD(-0.10)[text/plain]; ARC_SIGNED(0.00)[i=2]; DMARC_NA(0.00)[uoguelph.ca]; RCPT_COUNT_ONE(0.00)[1]; DWL_DNSWL_LOW(-1.00)[uoguelph.ca:dkim]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[uoguelph.ca:+]; NEURAL_HAM_SHORT(-1.24)[-1.243]; RCVD_IN_DNSWL_NONE(0.00)[40.107.67.76:from]; TO_DN_EQ_ADDR_ALL(0.00)[]; NEURAL_HAM_LONG(-0.97)[-0.973]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:8075, ipnet:40.104.0.0/14, country:US]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1]; RWL_MAILSPIKE_POSSIBLE(0.00)[40.107.67.76:from] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Aug 2020 15:42:26 -0000 Hi,=0A= =0A= I put D25923 up on phabricator a little while ago.=0A= I clicked on a couple of people that I thought might like to=0A= review it.=0A= =0A= However, if anyone else would like to review it, please do so.=0A= The review is as much about the concept as the actual implementation.=0A= =0A= Thanks, rick=0A= =0A= Here is the description of it...=0A= The kernel RPC cannot process non-application data records when=0A= using TLS. It must to an upcall to a userspace daemon that will=0A= call SSL_read() to process them.=0A= =0A= This patch adds a new flag called MSG_TLSAPPDATA that the kernel=0A= RPC can use to tell sorecieve() to return ENXIO instead of a non-applicat= ion=0A= data record, when that is what is at the top of the receive queue.=0A= =0A= The code could use any error return that is not normally returned by=0A= soreceive(). If some other errno is preferred, that can easily be changed= .=0A= =0A= I also put the code in #ifdef KERN_TLS/#endif, although it will build wit= hout=0A= that, so that it is recognized as only useful when KERN_TLS is enabled.= =0A= =0A= The alternative to doing this is to have the kernel RPC re-queue the=0A= non-application data message after receiving it, but that seems more=0A= complicated and might introduce message ordering issues when there=0A= are multiple non-application data records one after another.=0A= =0A= I do not know what, if any, changes will be required to support TLS1.3.= =0A=