From owner-cvs-all@FreeBSD.ORG Sat Dec 9 20:58:27 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0D9C616A412; Sat, 9 Dec 2006 20:58:27 +0000 (UTC) (envelope-from syrinx@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id AFDA543CA3; Sat, 9 Dec 2006 20:57:20 +0000 (GMT) (envelope-from syrinx@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kB9KwQmI077388; Sat, 9 Dec 2006 20:58:26 GMT (envelope-from syrinx@repoman.freebsd.org) Received: (from syrinx@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kB9KwQcI077387; Sat, 9 Dec 2006 20:58:26 GMT (envelope-from syrinx) Message-Id: <200612092058.kB9KwQcI077387@repoman.freebsd.org> From: Shteryana Shopova Date: Sat, 9 Dec 2006 20:58:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/bsnmpd/modules/snmp_bridge bridge_addrs.c bridge_if.c bridge_port.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Dec 2006 20:58:27 -0000 syrinx 2006-12-09 20:58:26 UTC FreeBSD src repository Modified files: usr.sbin/bsnmpd/modules/snmp_bridge bridge_addrs.c bridge_if.c bridge_port.c Log: Instead of explicitly initializing variables to avoid compiler warnings, add a default case to handle the situation when the variables are not initialized. Furthermore, abort() if the snmp agent passes an invalid option to the bridge module. As the option (SET, GET, GETNEXT, COMMIT, ROLLBACK) is determined by the snmp agent based on the operation requested by user, this behaviour is unlikely to be abused as a source for a DoS, but if ever hit will likely reveal a problem in the snmp agent or bridge module. Approved by: bz (mentor) Revision Changes Path 1.2 +4 -3 src/usr.sbin/bsnmpd/modules/snmp_bridge/bridge_addrs.c 1.3 +19 -4 src/usr.sbin/bsnmpd/modules/snmp_bridge/bridge_if.c 1.3 +19 -9 src/usr.sbin/bsnmpd/modules/snmp_bridge/bridge_port.c